* [PATCH] libata: hardreset on SERR_INTERNAL
@ 2007-03-13 16:20 Tejun Heo
2007-03-14 9:30 ` Jeff Garzik
2007-04-04 5:43 ` Jeff Garzik
0 siblings, 2 replies; 4+ messages in thread
From: Tejun Heo @ 2007-03-13 16:20 UTC (permalink / raw)
To: Jeff Garzik, linux-ide
There was a rare report where SB600 reported SERR_INTERNAL and SRST
couldn't get it out of the failure mode. Hardreset on SERR_INTERNAL.
As the problem is intermittent, whether this fixes the problem or not
hasn't been verified yet, but hardresetting the channel on internal
error is a good idea anyway.
Signed-off-by: Tejun Heo <htejun@gmail.com>
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index 7349c3d..fc11bb3 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -1055,7 +1055,7 @@ static void ata_eh_analyze_serror(struct ata_port *ap)
}
if (serror & SERR_INTERNAL) {
err_mask |= AC_ERR_SYSTEM;
- action |= ATA_EH_SOFTRESET;
+ action |= ATA_EH_HARDRESET;
}
if (serror & (SERR_PHYRDY_CHG | SERR_DEV_XCHG))
ata_ehi_hotplugged(&ehc->i);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] libata: hardreset on SERR_INTERNAL
2007-03-13 16:20 [PATCH] libata: hardreset on SERR_INTERNAL Tejun Heo
@ 2007-03-14 9:30 ` Jeff Garzik
2007-03-14 11:50 ` Tejun Heo
2007-04-04 5:43 ` Jeff Garzik
1 sibling, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2007-03-14 9:30 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide
Tejun Heo wrote:
> There was a rare report where SB600 reported SERR_INTERNAL and SRST
> couldn't get it out of the failure mode. Hardreset on SERR_INTERNAL.
> As the problem is intermittent, whether this fixes the problem or not
> hasn't been verified yet, but hardresetting the channel on internal
> error is a good idea anyway.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index 7349c3d..fc11bb3 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -1055,7 +1055,7 @@ static void ata_eh_analyze_serror(struct ata_port *ap)
> }
> if (serror & SERR_INTERNAL) {
> err_mask |= AC_ERR_SYSTEM;
> - action |= ATA_EH_SOFTRESET;
> + action |= ATA_EH_HARDRESET;
How does this interact with the patch ATI just posted, which prefers to
treat the SB600 SERR_INTERNAL differently?
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libata: hardreset on SERR_INTERNAL
2007-03-14 9:30 ` Jeff Garzik
@ 2007-03-14 11:50 ` Tejun Heo
0 siblings, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2007-03-14 11:50 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide
Jeff Garzik wrote:
> Tejun Heo wrote:
>> There was a rare report where SB600 reported SERR_INTERNAL and SRST
>> couldn't get it out of the failure mode. Hardreset on SERR_INTERNAL.
>> As the problem is intermittent, whether this fixes the problem or not
>> hasn't been verified yet, but hardresetting the channel on internal
>> error is a good idea anyway.
>
> How does this interact with the patch ATI just posted, which prefers to
> treat the SB600 SERR_INTERNAL differently?
Gee... That looks like the correct fix. Raising SERR_INTERNAL on ATAPI
CC never occurred to me. I still think hardresetting on SERR_INTERNAL
is better than softresetting tho.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libata: hardreset on SERR_INTERNAL
2007-03-13 16:20 [PATCH] libata: hardreset on SERR_INTERNAL Tejun Heo
2007-03-14 9:30 ` Jeff Garzik
@ 2007-04-04 5:43 ` Jeff Garzik
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2007-04-04 5:43 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide
Tejun Heo wrote:
> There was a rare report where SB600 reported SERR_INTERNAL and SRST
> couldn't get it out of the failure mode. Hardreset on SERR_INTERNAL.
> As the problem is intermittent, whether this fixes the problem or not
> hasn't been verified yet, but hardresetting the channel on internal
> error is a good idea anyway.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index 7349c3d..fc11bb3 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -1055,7 +1055,7 @@ static void ata_eh_analyze_serror(struct ata_port *ap)
> }
> if (serror & SERR_INTERNAL) {
> err_mask |= AC_ERR_SYSTEM;
> - action |= ATA_EH_SOFTRESET;
> + action |= ATA_EH_HARDRESET;
applied to #upstream
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-04-04 5:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-13 16:20 [PATCH] libata: hardreset on SERR_INTERNAL Tejun Heo
2007-03-14 9:30 ` Jeff Garzik
2007-03-14 11:50 ` Tejun Heo
2007-04-04 5:43 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).