* libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK
[not found] ` <20070330210659.GK29450@kroah.com>
@ 2007-03-30 21:45 ` Mark Lord
2007-03-31 3:36 ` Tejun Heo
2007-04-04 6:08 ` Jeff Garzik
0 siblings, 2 replies; 5+ messages in thread
From: Mark Lord @ 2007-03-30 21:45 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-kernel, alan, Tejun Heo, IDE/ATA development list
Ideally, this would go into linux-2.6.21.
Preserve the LBA bit in the DevSel/Head register for HDIO_DRIVE_TASK.
Signed-off-by: Mark Lord <mlord@pobox.com>
---
--- linux/drivers/ata/libata-scsi.c.orig 2007-03-21 13:35:02.000000000 -0400
+++ linux/drivers/ata/libata-scsi.c 2007-03-30 17:40:58.000000000 -0400
@@ -333,7 +333,7 @@
scsi_cmd[8] = args[3];
scsi_cmd[10] = args[4];
scsi_cmd[12] = args[5];
- scsi_cmd[13] = args[6] & 0x0f;
+ scsi_cmd[13] = args[6] & 0x4f;
scsi_cmd[14] = args[0];
/* Good values for timeout and retries? Values below
--
Mark Lord
Real-Time Remedies Inc.
mlord@pobox.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK
2007-03-30 21:45 ` libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK Mark Lord
@ 2007-03-31 3:36 ` Tejun Heo
2007-03-31 16:55 ` Mark Lord
2007-04-04 6:08 ` Jeff Garzik
1 sibling, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2007-03-31 3:36 UTC (permalink / raw)
To: Mark Lord; +Cc: Jeff Garzik, linux-kernel, alan, IDE/ATA development list
Mark Lord wrote:
> Ideally, this would go into linux-2.6.21.
>
> Preserve the LBA bit in the DevSel/Head register for HDIO_DRIVE_TASK.
>
> Signed-off-by: Mark Lord <mlord@pobox.com>
> ---
> --- linux/drivers/ata/libata-scsi.c.orig 2007-03-21
> 13:35:02.000000000 -0400
> +++ linux/drivers/ata/libata-scsi.c 2007-03-30 17:40:58.000000000 -0400
> @@ -333,7 +333,7 @@
> scsi_cmd[8] = args[3];
> scsi_cmd[10] = args[4];
> scsi_cmd[12] = args[5];
> - scsi_cmd[13] = args[6] & 0x0f;
> + scsi_cmd[13] = args[6] & 0x4f;
> scsi_cmd[14] = args[0];
>
> /* Good values for timeout and retries? Values below
IDE seems to be just overriding devsel (0x10) and leaving the rest
alone. Maybe we should do (args[6] & ~0x10) here? Or is it safer this way?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK
2007-03-31 3:36 ` Tejun Heo
@ 2007-03-31 16:55 ` Mark Lord
2007-03-31 17:05 ` Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: Mark Lord @ 2007-03-31 16:55 UTC (permalink / raw)
To: Tejun Heo; +Cc: Jeff Garzik, linux-kernel, alan, IDE/ATA development list
Tejun Heo wrote:
> Mark Lord wrote:
>> Ideally, this would go into linux-2.6.21.
>>
>> Preserve the LBA bit in the DevSel/Head register for HDIO_DRIVE_TASK.
>>
>> Signed-off-by: Mark Lord <mlord@pobox.com>
>> ---
>> --- linux/drivers/ata/libata-scsi.c.orig 2007-03-21
>> 13:35:02.000000000 -0400
>> +++ linux/drivers/ata/libata-scsi.c 2007-03-30 17:40:58.000000000 -0400
>> @@ -333,7 +333,7 @@
>> scsi_cmd[8] = args[3];
>> scsi_cmd[10] = args[4];
>> scsi_cmd[12] = args[5];
>> - scsi_cmd[13] = args[6] & 0x0f;
>> + scsi_cmd[13] = args[6] & 0x4f;
>> scsi_cmd[14] = args[0];
>>
>> /* Good values for timeout and retries? Values below
>
> IDE seems to be just overriding devsel (0x10) and leaving the rest
> alone. Maybe we should do (args[6] & ~0x10) here? Or is it safer this way?
Same thoughts here. I went "conservative" on this one,
because the entire field has been all zeros until this patch,
and I didn't want to trigger any possible latent bugs in libata.
Whatever.
Cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK
2007-03-31 16:55 ` Mark Lord
@ 2007-03-31 17:05 ` Tejun Heo
0 siblings, 0 replies; 5+ messages in thread
From: Tejun Heo @ 2007-03-31 17:05 UTC (permalink / raw)
To: Mark Lord; +Cc: Jeff Garzik, linux-kernel, alan, IDE/ATA development list
Mark Lord wrote:
> Tejun Heo wrote:
>> Mark Lord wrote:
>>> Ideally, this would go into linux-2.6.21.
>>>
>>> Preserve the LBA bit in the DevSel/Head register for HDIO_DRIVE_TASK.
>>>
>>> Signed-off-by: Mark Lord <mlord@pobox.com>
>>> ---
>>> --- linux/drivers/ata/libata-scsi.c.orig 2007-03-21
>>> 13:35:02.000000000 -0400
>>> +++ linux/drivers/ata/libata-scsi.c 2007-03-30 17:40:58.000000000
>>> -0400
>>> @@ -333,7 +333,7 @@
>>> scsi_cmd[8] = args[3];
>>> scsi_cmd[10] = args[4];
>>> scsi_cmd[12] = args[5];
>>> - scsi_cmd[13] = args[6] & 0x0f;
>>> + scsi_cmd[13] = args[6] & 0x4f;
>>> scsi_cmd[14] = args[0];
>>>
>>> /* Good values for timeout and retries? Values below
>>
>> IDE seems to be just overriding devsel (0x10) and leaving the rest
>> alone. Maybe we should do (args[6] & ~0x10) here? Or is it safer
>> this way?
>
> Same thoughts here. I went "conservative" on this one,
> because the entire field has been all zeros until this patch,
> and I didn't want to trigger any possible latent bugs in libata.
>
> Whatever.
Yeah, I agree 'whatever' should work here. :-)
Acked-by: Tejun Heo <htejun@gmail.com>
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK
2007-03-30 21:45 ` libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK Mark Lord
2007-03-31 3:36 ` Tejun Heo
@ 2007-04-04 6:08 ` Jeff Garzik
1 sibling, 0 replies; 5+ messages in thread
From: Jeff Garzik @ 2007-04-04 6:08 UTC (permalink / raw)
To: Mark Lord; +Cc: linux-kernel, alan, Tejun Heo, IDE/ATA development list
Mark Lord wrote:
> Ideally, this would go into linux-2.6.21.
>
> Preserve the LBA bit in the DevSel/Head register for HDIO_DRIVE_TASK.
>
> Signed-off-by: Mark Lord <mlord@pobox.com>
> ---
> --- linux/drivers/ata/libata-scsi.c.orig 2007-03-21
> 13:35:02.000000000 -0400
> +++ linux/drivers/ata/libata-scsi.c 2007-03-30 17:40:58.000000000 -0400
> @@ -333,7 +333,7 @@
> scsi_cmd[8] = args[3];
> scsi_cmd[10] = args[4];
> scsi_cmd[12] = args[5];
> - scsi_cmd[13] = args[6] & 0x0f;
> + scsi_cmd[13] = args[6] & 0x4f;
> scsi_cmd[14] = args[0];
applied
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-04-04 6:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20070330205938.984247529@mini.kroah.org>
[not found] ` <20070330210659.GK29450@kroah.com>
2007-03-30 21:45 ` libata bugfix: preserve LBA bit for HDIO_DRIVE_TASK Mark Lord
2007-03-31 3:36 ` Tejun Heo
2007-03-31 16:55 ` Mark Lord
2007-03-31 17:05 ` Tejun Heo
2007-04-04 6:08 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).