From: Jeff Garzik <jeff@garzik.org>
To: albertl@mail.com
Cc: Linux IDE <linux-ide@vger.kernel.org>, YUP <yupadmin@gmail.com>,
Vlad Codrea <VladCodrea@mail.utexas.edu>
Subject: Re: [PATCH 1/4] libata: reorder HSM_ST_FIRST for easier decoding (take 3)
Date: Wed, 04 Apr 2007 02:12:37 -0400 [thread overview]
Message-ID: <461341D5.30702@garzik.org> (raw)
In-Reply-To: <46107874.3060904@tw.ibm.com>
Albert Lee wrote:
> patch 1/4:
> Reorder HSM_ST_FIRST, such that the task state transition is easier decoded with human eyes.
>
> Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
> ---
> Patch against libata-dev tree, for your review, thanks.
>
> diff -Nrup 00_libata-dev.ori/include/linux/libata.h 01_hsm_st/include/linux/libata.h
> --- 00_libata-dev.ori/include/linux/libata.h 2007-03-23 16:56:24.000000000 +0800
> +++ 01_hsm_st/include/linux/libata.h 2007-04-02 10:50:50.000000000 +0800
> @@ -315,11 +315,11 @@ enum {
>
> enum hsm_task_states {
> HSM_ST_IDLE, /* no command on going */
> + HSM_ST_FIRST, /* (waiting the device to)
> + write CDB or first data block */
> HSM_ST, /* (waiting the device to) transfer data */
> HSM_ST_LAST, /* (waiting the device to) complete command */
> HSM_ST_ERR, /* error */
> - HSM_ST_FIRST, /* (waiting the device to)
> - write CDB or first data block */
> };
applied 1-4
next prev parent reply other threads:[~2007-04-04 6:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-02 3:26 [PATCH 0/4] libata: Workaround/fixes for ATAPI devices (take 3) Albert Lee
2007-04-02 3:28 ` [PATCH 1/4] libata: reorder HSM_ST_FIRST for easier decoding " Albert Lee
2007-04-04 6:12 ` Jeff Garzik [this message]
2007-04-02 3:30 ` [PATCH 2/4] libata: Clear tf before doing request sense " Albert Lee
2007-04-02 3:34 ` [PATCH 3/4] libata: Limit max sector to 128 for TORiSAN DVD drives " Albert Lee
2007-04-02 3:39 ` [PATCH 4/4] libata: Limit ATAPI DMA to R/W commands only " Albert Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461341D5.30702@garzik.org \
--to=jeff@garzik.org \
--cc=VladCodrea@mail.utexas.edu \
--cc=albertl@mail.com \
--cc=linux-ide@vger.kernel.org \
--cc=yupadmin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).