From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [patch 2/3] libata: expose AN support to user space via sysfs Date: Thu, 05 Apr 2007 04:03:20 -0400 Message-ID: <4614AD48.1080005@pobox.com> References: <20070328230108.597741522@intel.com> <20070328164450.b89d5156.kristen.c.accardi@intel.com> <460B0539.9040103@pobox.com> <460B1F6B.5050108@gmail.com> <460B2249.4010200@pobox.com> <460B26AB.8060307@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <460B26AB.8060307@gmail.com> Sender: linux-scsi-owner@vger.kernel.org To: Tejun Heo Cc: Kristen Carlson Accardi , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-ide@vger.kernel.org, linux-scsi List-Id: linux-ide@vger.kernel.org Tejun Heo wrote: > Jeff Garzik wrote: >> AN is a generic concept that I feel will propagate elsewhere. > > I think SCSI already has it or am I imagining things again? :-) > >> Though perhaps it should be in a 'capability_flags' file rather than a >> 'media_change_event' file. > > IMHO, if it's genhd.capability_flags then the flag should be > MEDIA_CHANGE_NOTIFY not ASYNC_NOTIFICATION because AN itself doesn't > imply any specific event. It's just a notification mechanism, for ATAPI > devices, it means media change, for PMP it has a different meaning, so I > think we need to export the processed meaning not the specific mechanism > to userland. Agreed, sounds good. Jeff