From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jan-Benedict Glaw <jbglaw@lug-owl.de>,
akpm@osdl.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, kyle@canonical.com
Subject: Re: [PATCH] HPA support: Revised patch
Date: Thu, 05 Apr 2007 16:30:08 -0400 [thread overview]
Message-ID: <46155C50.8000003@garzik.org> (raw)
In-Reply-To: <20070405211804.1f64e515@the-village.bc.nu>
Alan Cox wrote:
>>> +static int ata_ignore_hpa = 0;
>>> +module_param_named(ignore_hpa, ata_ignore_hpa, int, 0644);
>>> +MODULE_PARM_DESC(ignore_hpa, "Ignore HPA (0=off 1=on)");
>>> +
>>> static int ata_probe_timeout = ATA_TMOUT_INTERNAL / HZ;
>>> module_param(ata_probe_timeout, int, 0444);
>>> MODULE_PARM_DESC(ata_probe_timeout, "Set ATA probing timeout (seconds)");
>> For ignore_hpa, it would be nice to not go through inverse logic and
>> fix the help text a bit (0=honor HPA, 1=ignore HPA).
>
> Umm.. how about "preserve_hpa" ?
I think he meant fix the help text?
Regardless, it should be "ignore_hpa" as you have it now, though I feel
the help text requires additional human brain parsing, and could be more
clear.
Jeff
next prev parent reply other threads:[~2007-04-05 20:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-05 13:13 [PATCH] HPA support: Revised patch Alan Cox
2007-04-05 16:25 ` Randy Dunlap
2007-04-05 19:24 ` Jan-Benedict Glaw
2007-04-05 20:18 ` Alan Cox
2007-04-05 20:30 ` Jeff Garzik [this message]
2007-04-06 16:37 ` Matthew Garrett
2007-04-09 21:22 ` Alan Cox
2007-04-09 21:55 ` Chuck Ebbert
2007-04-10 14:06 ` Matthew Garrett
2007-04-10 14:07 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46155C50.8000003@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jbglaw@lug-owl.de \
--cc=kyle@canonical.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).