From: Jeff Garzik <jeff@garzik.org>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH libata#upstream] sata_promise: fix error decode regression
Date: Tue, 17 Apr 2007 10:29:45 -0400 [thread overview]
Message-ID: <4624D9D9.6020502@garzik.org> (raw)
In-Reply-To: <200704071229.l37CTp6M010861@harpo.it.uu.se>
Mikael Pettersson wrote:
> Promise ATA ports should always be reset by pdc_reset_port()
> when errors are detected, but the recent error reason decoding
> update to sata_promise replaced that reset with a freeze.
>
> This patch changes the error detection to do a reset again.
> This makes the error decoding update safer, as it now only
> adds error decoding without changing any other behaviour.
>
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
> ---
> drivers/ata/sata_promise.c | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
applied
next prev parent reply other threads:[~2007-04-17 14:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-07 12:29 [PATCH libata#upstream] sata_promise: fix error decode regression Mikael Pettersson
2007-04-09 7:52 ` Tejun Heo
2007-04-17 14:29 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-04-09 8:54 Mikael Pettersson
2007-04-09 9:16 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4624D9D9.6020502@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).