From: Tejun Heo <htejun@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: 7eggert@gmx.de, Chuck Ebbert <cebbert@redhat.com>,
emisca <emisca.ml@gmail.com>,
Jan Engelhardt <jengelh@linux01.gwdg.de>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org, Adrian Bunk <bunk@stusta.de>,
Andrew Morton <akpm@osdl.org>
Subject: Re: Loud "pop" coming from hard drive on reboot
Date: Wed, 18 Apr 2007 22:05:57 +0900 [thread overview]
Message-ID: <462617B5.8050205@gmail.com> (raw)
In-Reply-To: <20070418140346.636879a1@the-village.bc.nu>
Alan Cox wrote:
>> Thought about that and querying power state before doing shutdown
>> sequence but things get somewhat ugly because shutdown sequence is
>> driven from sd->shutdown(). We'll have to snoop both sync and shutdown
>> commands and check whether the system is shutting down. Also, I felt
>> very uneasy about faking successful completion to SYNCHRONIZE_CACHE.
>
> If you see a synchronize cache succeed and you then see the drive
> shutdown succeed then you know that a sync cache can be faked as ok
> safely. Any other command in between or after and it doesn't get faked
>
> This seems pretty easy to deal with at command issue.
Yeah, right. I guess I'm too anal about SYNCHRONIZE_CACHE.
>> I dunno. It's already too late for 2.6.21. I was hoping we could get
>> distros to update shutdown utilities in not-too-distant future but I
>> have no experience with that. Is that just a wishful thinking?
>
> Probably not, but it will take a year or so and throughout this time
> period everyone with the wrong combination of shutdown and kernel (which
> will be a lot of people who compile their own kernels) are going to have
> problems caused by what is a very obscure piece of libata internal
> behaviour they'll never even know about.
Okay, will do another round of the patch.
Thanks.
--
tejun
next prev parent reply other threads:[~2007-04-18 13:06 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <88SeR-5Sf-15@gated-at.bofh.it>
[not found] ` <88Sov-662-3@gated-at.bofh.it>
[not found] ` <88SHV-6uL-29@gated-at.bofh.it>
[not found] ` <8agVk-3wc-81@gated-at.bofh.it>
[not found] ` <8b3IR-4mE-25@gated-at.bofh.it>
[not found] ` <8b3SA-4z3-5@gated-at.bofh.it>
[not found] ` <8b42g-51N-15@gated-at.bofh.it>
[not found] ` <8bbdm-7iS-27@gated-at.bofh.it>
2007-04-18 11:47 ` Loud "pop" coming from hard drive on reboot Bodo Eggert
2007-04-18 12:05 ` Tejun Heo
2007-04-18 12:29 ` Alan Cox
2007-04-18 12:46 ` Tejun Heo
2007-04-18 12:50 ` Tejun Heo
2007-04-18 13:03 ` Alan Cox
2007-04-18 13:05 ` Tejun Heo [this message]
2007-04-18 13:39 ` Stephen Clark
2007-04-19 7:18 ` Jan Engelhardt
2007-04-19 12:59 ` Stephen Clark
2007-04-19 13:32 ` Mark Lord
2007-04-18 14:32 ` Mark Lord
2007-04-18 14:35 ` Mark Lord
2007-04-18 15:06 ` Alan Cox
2007-04-18 15:16 ` Mark Lord
2007-04-18 15:25 ` Tejun Heo
2007-04-18 17:08 ` Mark Lord
2007-04-18 17:19 ` Mark Lord
2007-04-18 17:46 ` Chuck Ebbert
2007-04-18 21:22 ` Bartlomiej Zolnierkiewicz
2007-04-18 21:27 ` Chuck Ebbert
2007-04-21 23:20 ` Peter Zijlstra
2007-04-23 23:27 ` Chuck Ebbert
2007-04-18 21:29 ` Greg Freemyer
2007-04-18 17:46 ` Stephen Clark
2007-04-19 17:50 ` Chuck Ebbert
2007-04-20 12:15 ` Stephen Clark
2007-04-20 19:57 ` Fabio Comolli
2007-04-21 9:45 ` emisca
2007-04-21 9:50 ` Fabio Comolli
2007-04-21 14:33 ` Jan Engelhardt
2007-04-21 15:11 ` Fabio Comolli
2007-04-18 17:04 ` Stephen Clark
2007-04-11 21:07 Chuck Ebbert
2007-04-11 21:16 ` Jan Engelhardt
2007-04-11 21:35 ` Chuck Ebbert
2007-04-11 21:49 ` Jan Engelhardt
2007-04-11 22:07 ` Chuck Ebbert
2007-04-13 19:42 ` Bartlomiej Zolnierkiewicz
2007-04-13 19:36 ` Chuck Ebbert
2007-04-13 20:47 ` Bartlomiej Zolnierkiewicz
2007-04-13 21:13 ` Chuck Ebbert
2007-04-15 16:07 ` emisca
2007-04-17 21:41 ` Mark Lord
2007-04-17 21:49 ` Chuck Ebbert
2007-04-17 22:03 ` Mark Lord
2007-04-18 5:39 ` Tejun Heo
2007-04-18 21:31 ` Bartlomiej Zolnierkiewicz
2007-04-18 23:36 ` Mark Lord
2007-04-18 23:51 ` Mark Lord
2007-04-14 10:52 ` Pavel Machek
2007-04-15 15:53 ` Henrique de Moraes Holschuh
2007-04-15 18:50 ` Jan Engelhardt
2007-04-16 22:26 ` Chuck Ebbert
2007-04-17 7:00 ` emisca
2007-04-17 7:37 ` Fabio Comolli
2007-04-17 20:15 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=462617B5.8050205@gmail.com \
--to=htejun@gmail.com \
--cc=7eggert@gmx.de \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bunk@stusta.de \
--cc=bzolnier@gmail.com \
--cc=cebbert@redhat.com \
--cc=emisca.ml@gmail.com \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).