From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: Loud "pop" coming from hard drive on reboot Date: Wed, 18 Apr 2007 22:05:57 +0900 Message-ID: <462617B5.8050205@gmail.com> References: <88SeR-5Sf-15@gated-at.bofh.it> <88Sov-662-3@gated-at.bofh.it> <88SHV-6uL-29@gated-at.bofh.it> <8agVk-3wc-81@gated-at.bofh.it> <8b3IR-4mE-25@gated-at.bofh.it> <8b3SA-4z3-5@gated-at.bofh.it> <8b42g-51N-15@gated-at.bofh.it> <8bbdm-7iS-27@gated-at.bofh.it> <46260981.1040109@gmail.com> <20070418132904.3322ba5f@the-village.bc.nu> <46261337.3010406@gmail.com> <20070418140346.636879a1@the-village.bc.nu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from nz-out-0506.google.com ([64.233.162.229]:58923 "EHLO nz-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422991AbXDRNGF (ORCPT ); Wed, 18 Apr 2007 09:06:05 -0400 Received: by nz-out-0506.google.com with SMTP id s1so119930nze for ; Wed, 18 Apr 2007 06:06:04 -0700 (PDT) In-Reply-To: <20070418140346.636879a1@the-village.bc.nu> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cox Cc: 7eggert@gmx.de, Chuck Ebbert , emisca , Jan Engelhardt , Bartlomiej Zolnierkiewicz , linux-kernel , linux-ide@vger.kernel.org, Adrian Bunk , Andrew Morton Alan Cox wrote: >> Thought about that and querying power state before doing shutdown >> sequence but things get somewhat ugly because shutdown sequence is >> driven from sd->shutdown(). We'll have to snoop both sync and shutdown >> commands and check whether the system is shutting down. Also, I felt >> very uneasy about faking successful completion to SYNCHRONIZE_CACHE. > > If you see a synchronize cache succeed and you then see the drive > shutdown succeed then you know that a sync cache can be faked as ok > safely. Any other command in between or after and it doesn't get faked > > This seems pretty easy to deal with at command issue. Yeah, right. I guess I'm too anal about SYNCHRONIZE_CACHE. >> I dunno. It's already too late for 2.6.21. I was hoping we could get >> distros to update shutdown utilities in not-too-distant future but I >> have no experience with that. Is that just a wishful thinking? > > Probably not, but it will take a year or so and throughout this time > period everyone with the wrong combination of shutdown and kernel (which > will be a lot of people who compile their own kernels) are going to have > problems caused by what is a very obscure piece of libata internal > behaviour they'll never even know about. Okay, will do another round of the patch. Thanks. -- tejun