Re: libata Intel PIIX/ICH fails to detect both PATA drives, spews ACPI errors

["Berck E. Nash" <flyboy@gmail.com>]

Tejun Heo wrote:
>>>>> Berck E. Nash wrote:
>>>>>> Testing the new libata ICH PATA drivers.  There's one PATA port on this
>>>>>> chip, and I've got two optical drives connected to it.  The master drive
>>>>>> fails to detect.  The slave detects and works properly.
>>>>> Can you test 2.6.20.1 and post full dmesg?
>>>> Here's 2.6.20.2...  No ACPI errors, but still doesn't detect both drives.
>>> Please apply the attached patch and see if it works.  If it works,
>>> please post the result of hdparm -I /dev/srX of the optical drive.  Thanks.

> ------------------------------------------------------------------------
> 
> diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
> index dc42ba1..6e7775a 100644
> --- a/drivers/ata/ata_piix.c
> +++ b/drivers/ata/ata_piix.c
> @@ -105,7 +105,8 @@ enum {
>  	PIIX_FLAG_AHCI		= (1 << 27), /* AHCI possible */
>  	PIIX_FLAG_CHECKINTR	= (1 << 28), /* make sure PCI INTx enabled */
>  
> -	PIIX_PATA_FLAGS		= ATA_FLAG_SLAVE_POSS,
> +	PIIX_PATA_FLAGS		= ATA_FLAG_SLAVE_POSS |
> +				  ATA_FLAG_SETXFER_POLLING,
>  	PIIX_SATA_FLAGS		= ATA_FLAG_SATA | PIIX_FLAG_CHECKINTR,
>  
>  	/* combined mode.  if set, PATA is channel 0.

Since this patch fixes the problem, is there some reason it still hasn't
been included?

Berck