* [PATCH] libata: add missing call to ->cable_detect() in new EH path
@ 2007-04-22 17:05 Tejun Heo
2007-04-22 17:39 ` Alan Cox
2007-04-28 18:46 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Tejun Heo @ 2007-04-22 17:05 UTC (permalink / raw)
To: Jeff Garzik, Alan Cox, linux-ide
->cable_detect() used to be called on by the old ata_bus_probe() path.
Add invocation to ata_eh_revalidate_and_attach() right after IDENTIFYs
are done.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
---
drivers/ata/libata-eh.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index 0dbee55..67bf150 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -1810,6 +1810,10 @@ static int ata_eh_revalidate_and_attach(struct ata_port *ap,
}
}
+ /* PDIAG- should have been released, ask cable type if post-reset */
+ if ((ehc->i.flags & ATA_EHI_DID_RESET) && ap->ops->cable_detect)
+ ap->cbl = ap->ops->cable_detect(ap);
+
/* Configure new devices forward such that user doesn't see
* device detection messages backwards.
*/
--
1.5.0.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libata: add missing call to ->cable_detect() in new EH path
2007-04-22 17:05 [PATCH] libata: add missing call to ->cable_detect() in new EH path Tejun Heo
@ 2007-04-22 17:39 ` Alan Cox
2007-04-28 18:46 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Alan Cox @ 2007-04-22 17:39 UTC (permalink / raw)
To: Tejun Heo; +Cc: Jeff Garzik, linux-ide
On Mon, 23 Apr 2007 02:05:53 +0900
Tejun Heo <htejun@gmail.com> wrote:
> ->cable_detect() used to be called on by the old ata_bus_probe() path.
> Add invocation to ata_eh_revalidate_and_attach() right after IDENTIFYs
> are done.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Acked-by: Alan Cox <alan@redhat.com>
I need to push the "if the drive is SATA the cable is SATA " patch once
all this has settled too.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libata: add missing call to ->cable_detect() in new EH path
2007-04-22 17:05 [PATCH] libata: add missing call to ->cable_detect() in new EH path Tejun Heo
2007-04-22 17:39 ` Alan Cox
@ 2007-04-28 18:46 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2007-04-28 18:46 UTC (permalink / raw)
To: Tejun Heo; +Cc: Alan Cox, linux-ide
Tejun Heo wrote:
> ->cable_detect() used to be called on by the old ata_bus_probe() path.
> Add invocation to ata_eh_revalidate_and_attach() right after IDENTIFYs
> are done.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> ---
> drivers/ata/libata-eh.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-04-28 18:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-22 17:05 [PATCH] libata: add missing call to ->cable_detect() in new EH path Tejun Heo
2007-04-22 17:39 ` Alan Cox
2007-04-28 18:46 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).