From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata-acpi: fix _GTF command protocol for ATAPI devices
Date: Sat, 28 Apr 2007 14:53:24 -0400 [thread overview]
Message-ID: <46339824.5000107@garzik.org> (raw)
In-Reply-To: <20070422170646.GM10619@htj.dyndns.org>
Tejun Heo wrote:
> _GTF command is never ATA_PROT_ATAPI_NODATA whether the device is
> ATAPI or not. It's always ATA_PROT_NODATA.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-acpi.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
> index 03a0acf..cb3eab6 100644
> --- a/drivers/ata/libata-acpi.c
> +++ b/drivers/ata/libata-acpi.c
> @@ -489,8 +489,7 @@ static void taskfile_load_raw(struct ata_port *ap,
>
> /* convert gtf to tf */
> tf.flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE; /* TBD */
> - tf.protocol = atadev->class == ATA_DEV_ATAPI ?
> - ATA_PROT_ATAPI_NODATA : ATA_PROT_NODATA;
> + tf.protocol = ATA_PROT_NODATA;
Elaboration?
ATA_PROT_ATAPI_NODATA is the ATAPI version of the non-data protocol, so
this change is unexpected.
Jeff
next prev parent reply other threads:[~2007-04-28 18:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-22 17:06 [PATCH] libata-acpi: fix _GTF command protocol for ATAPI devices Tejun Heo
2007-04-22 17:38 ` Alan Cox
2007-04-28 18:53 ` Jeff Garzik [this message]
2007-04-29 2:51 ` Tejun Heo
2007-04-29 3:13 ` Jeff Garzik
2007-05-10 0:16 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46339824.5000107@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).