linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: akpm@linux-foundation.org
Cc: linux-ide@vger.kernel.org, alan@lxorguk.ukuu.org.uk, htejun@gmail.com
Subject: Re: [patch 08/10] drivers/ata/pata_cmd640.c: fix build with CONFIG_PM=n
Date: Sat, 28 Apr 2007 15:17:10 -0400	[thread overview]
Message-ID: <46339DB6.2030505@garzik.org> (raw)
In-Reply-To: <200704260719.l3Q7JQ8B023700@shell0.pdx.osdl.net>

akpm@linux-foundation.org wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> 
> This is grubby, but all the ata drivers do it this way.
> 
> Would it not be better to do
> 
> #define ata_scsi_device_resume NULL
> 
> in libata.h, remove all those ifdefs?
> 
> (updated version, ug, ug)
> 
> Cc: Jeff Garzik <jeff@garzik.org>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Cc: Tejun Heo <htejun@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/ata/pata_cmd640.c |    8 ++++++++
>  1 file changed, 8 insertions(+)

applied 8-9



      reply	other threads:[~2007-04-28 19:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-26  7:19 [patch 08/10] drivers/ata/pata_cmd640.c: fix build with CONFIG_PM=n akpm
2007-04-28 19:17 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46339DB6.2030505@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).