Re: [PATCH] libata: Handle drives that require a spin-up command before first access

[Mark Lord <liml@rtr.ca>]

Jeff Garzik wrote:
> Mark Lord wrote:
>
>> This patch adds support to libata for the "power-up in standby"
>> mode where a "spin up now!" command (SET_FEATURES) is needed.
>> With this, libata will recognize such drives, spin them up,
>> and then re-IDENTIFY them if necessary to get a full/complete
>> set of drive features data.
>>
>> Drives in this state are determined by looking for
>> special values in id[2], as documented in the current ATA specs.
>>
>> Signed-off-by: Mark Lord <mlord@pobox.com>
> 
> applied
> 
> though I'm curious where the verify step went, that was in the previous 
> rev of the patch

Hi Jeff,

The difference between this patch and the first RFC version,
is that I've dropped the code that attempted to deal with
the *other* kind of power-up-in-standby that some drives use.

That form is enabled with a Jumper setting on the drive
(eg. WD 37GB Raptor drives) rather than through software,
and I was unable to figure out exactly what they wanted
while I still had them here to experiment on.

Those drives are no longer in my possession, so.. no support.

The majority of drives use the software enable/disable form,
which is (still) fully addressed by the patch you applied.

Thanks!

-ml