Re: [patch 02/10] sata_nv: add back some verbosity into ADMA error_handler

[Jeff Garzik <jeff@garzik.org>]

Robert Hancock wrote:
> Jeff Garzik wrote:
>> akpm@linux-foundation.org wrote:
>>> From: Robert Hancock <hancockr@shaw.ca>
>>>
>>> Some debug output in the ADMA error_handler function was removed 
>>> recently,
>>> but it may be useful in certain cases, like NCQ commands timing out.  
>>> Add
>>> it back in, but make it a bit more intelligent so that it only prints if
>>> command(s) are active and only prints the CPBs for those commands.  That
>>> way it won't spew at inappropriate times like suspend/resume.
>>>
>>> [akpm@osdl.org: cleanup]
>>> Signed-off-by: Robert Hancock <hancockr@shaw.ca>
>>> Cc: Jeff Garzik <jeff@garzik.org>
>>> Cc: Tejun Heo <htejun@gmail.com>
>>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>>> ---
>>>
>>>  drivers/ata/sata_nv.c |   31 +++++++++++++++++++++++++++++--
>>>  1 file changed, 29 insertions(+), 2 deletions(-)
>>
>> Robert, is this patch still wanted?
>>
>> It looks OK; I've held because I thought it was created to debug a 
>> special situation.
>>
>> But I might be mistaken...
>>
>>     Jeff
> 
> Wait a minute, this patch is essentially already merged in mainline:
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=2cb27853b7cbf0c908444e25c61b62fa336b88cd 
> 
> 
> The only part that hasn't been merged is the whitespace cleanup that 
> Andrew added in his tree.

ah, indeed.  That's probably why my scripts thought the changes had not 
yet been applied.

Sorry for the noise.

	Jeff