From: Jeff Garzik <jgarzik@pobox.com>
To: Mark Lord <liml@rtr.ca>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [Fwd: Re: PATCH: libata: add support for ATA_16 on ATAPI]
Date: Thu, 03 May 2007 08:18:44 -0400 [thread overview]
Message-ID: <4639D324.5090908@pobox.com> (raw)
In-Reply-To: <46394ADA.1020400@rtr.ca>
Mark Lord wrote:
> Jeff?
> This has been pending for a very long time now.
>
> This patch brings libata up to similar standards as Linux IDE
> with support for things like hdparm -I (identify) and -C (check power)
> among others on ATAPI drives.
>
> Andrew, can you pick this up for -mm ??
>
> ???
My reluctance stems mainly from the modifications to the hot path. ATA
and ATAPI need wholly different command simulations, so I don't like
your modification of sending both ATA and ATAPI devices to the same
simulation function -- only to have to disambiguate with an ATA-or-ATAPI
test.
I would rather keep the branch in the queuecommand hook the same. That
should keep the ATA device callpath unchanged, while enabling what you
want on the ATAPI callpath.
Jeff
next prev parent reply other threads:[~2007-05-03 12:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 2:37 [Fwd: Re: PATCH: libata: add support for ATA_16 on ATAPI] Mark Lord
2007-05-03 12:18 ` Jeff Garzik [this message]
2007-05-03 13:34 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4639D324.5090908@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).