[PATCH] sata_via: add missing PM hooks

linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] sata_via: add missing PM hooks
@ 2007-05-04 13:30 Tejun Heo
  2007-05-08  9:54 ` Jeroen Janssen
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Tejun Heo @ 2007-05-04 13:30 UTC (permalink / raw)
  To: Jeff Garzik, IDE/ATA development list, stable; +Cc: Jeroen Janssen

For some reason, sata_via is missing PM hooks.  Add them.  Spotted by
Jeroen Janssen <jeroen.janssen@gmail.com>.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Jeroen Janssen <jeroen.janssen@gmail.com>
---
I have no idea how we missed this.  This is for both libata-dev &&
-stable.  Thanks.

Index: tree0/drivers/ata/sata_via.c
===================================================================
--- tree0.orig/drivers/ata/sata_via.c
+++ tree0/drivers/ata/sata_via.c
@@ -97,6 +97,10 @@ static struct pci_driver svia_pci_driver
 	.name			= DRV_NAME,
 	.id_table		= svia_pci_tbl,
 	.probe			= svia_init_one,
+#ifdef CONFIG_PM
+	.suspend		= ata_pci_device_suspend,
+	.resume			= ata_pci_device_resume,
+#endif
 	.remove			= ata_pci_remove_one,
 };
 
@@ -116,6 +120,10 @@ static struct scsi_host_template svia_sh
 	.slave_configure	= ata_scsi_slave_config,
 	.slave_destroy		= ata_scsi_slave_destroy,
 	.bios_param		= ata_std_bios_param,
+#ifdef CONFIG_PM
+	.suspend		= ata_scsi_device_suspend,
+	.resume			= ata_scsi_device_resume,
+#endif
 };
 
 static const struct ata_port_operations vt6420_sata_ops = {

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] sata_via: add missing PM hooks
  2007-05-04 13:30 [PATCH] sata_via: add missing PM hooks Tejun Heo
@ 2007-05-08  9:54 ` Jeroen Janssen
  2007-05-08 10:27   ` Tejun Heo
  2007-05-10  0:17 ` Jeff Garzik
  2007-05-17  1:52 ` patch sata_via-add-missing-pm-hooks.patch queued to 2.6.21-stable tree chrisw
  2 siblings, 1 reply; 8+ messages in thread
From: Jeroen Janssen @ 2007-05-08  9:54 UTC (permalink / raw)
  To: Tejun Heo; +Cc: Jeff Garzik, IDE/ATA development list, stable

Hi,

Any idea how I can track that this has been picked up/applied (I
looked at some of the git repositories on kernel.org, but as far as I
can tell, this patch is not in yet).

Best regards,

Jeroen Janssen

On 5/4/07, Tejun Heo <htejun@gmail.com> wrote:
> For some reason, sata_via is missing PM hooks.  Add them.  Spotted by
> Jeroen Janssen <jeroen.janssen@gmail.com>.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Jeroen Janssen <jeroen.janssen@gmail.com>
> ---
> I have no idea how we missed this.  This is for both libata-dev &&
> -stable.  Thanks.
>
> Index: tree0/drivers/ata/sata_via.c
> ===================================================================
> --- tree0.orig/drivers/ata/sata_via.c
> +++ tree0/drivers/ata/sata_via.c
> @@ -97,6 +97,10 @@ static struct pci_driver svia_pci_driver
>         .name                   = DRV_NAME,
>         .id_table               = svia_pci_tbl,
>         .probe                  = svia_init_one,
> +#ifdef CONFIG_PM
> +       .suspend                = ata_pci_device_suspend,
> +       .resume                 = ata_pci_device_resume,
> +#endif
>         .remove                 = ata_pci_remove_one,
>  };
>
> @@ -116,6 +120,10 @@ static struct scsi_host_template svia_sh
>         .slave_configure        = ata_scsi_slave_config,
>         .slave_destroy          = ata_scsi_slave_destroy,
>         .bios_param             = ata_std_bios_param,
> +#ifdef CONFIG_PM
> +       .suspend                = ata_scsi_device_suspend,
> +       .resume                 = ata_scsi_device_resume,
> +#endif
>  };
>
>  static const struct ata_port_operations vt6420_sata_ops = {
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] sata_via: add missing PM hooks
  2007-05-08  9:54 ` Jeroen Janssen
@ 2007-05-08 10:27   ` Tejun Heo
  0 siblings, 0 replies; 8+ messages in thread
From: Tejun Heo @ 2007-05-08 10:27 UTC (permalink / raw)
  To: Jeroen Janssen; +Cc: Jeff Garzik, IDE/ATA development list, stable

Jeroen Janssen wrote:
> Hi,
> 
> Any idea how I can track that this has been picked up/applied (I
> looked at some of the git repositories on kernel.org, but as far as I
> can tell, this patch is not in yet).

It's still pending.  What usually happens is Jeff replying with the body
saying 'applied' and the patch gets into libata-dev#upstream or
#upstream-fixes and then merged into Linus's tree.  For stable release,
after Jeff acks it, Greg or any other stable team member picks it up and
writes a formatted mail about it to everyone on the S-O-B: or Cc: list
and stable mailing list.  So, nope, it hasn't happend yet but you'll get
a notice when it happens.

-- 
tejun

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] sata_via: add missing PM hooks
  2007-05-04 13:30 [PATCH] sata_via: add missing PM hooks Tejun Heo
  2007-05-08  9:54 ` Jeroen Janssen
@ 2007-05-10  0:17 ` Jeff Garzik
  2007-05-17  1:52 ` patch sata_via-add-missing-pm-hooks.patch queued to 2.6.21-stable tree chrisw
  2 siblings, 0 replies; 8+ messages in thread
From: Jeff Garzik @ 2007-05-10  0:17 UTC (permalink / raw)
  To: Tejun Heo; +Cc: IDE/ATA development list, stable, Jeroen Janssen

Tejun Heo wrote:
> For some reason, sata_via is missing PM hooks.  Add them.  Spotted by
> Jeroen Janssen <jeroen.janssen@gmail.com>.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Jeroen Janssen <jeroen.janssen@gmail.com>
> ---
> I have no idea how we missed this.  This is for both libata-dev &&
> -stable.  Thanks.

applied



^ permalink raw reply	[flat|nested] 8+ messages in thread

* patch sata_via-add-missing-pm-hooks.patch queued to 2.6.21-stable tree
  2007-05-04 13:30 [PATCH] sata_via: add missing PM hooks Tejun Heo
  2007-05-08  9:54 ` Jeroen Janssen
  2007-05-10  0:17 ` Jeff Garzik
@ 2007-05-17  1:52 ` chrisw
  2 siblings, 0 replies; 8+ messages in thread
From: chrisw @ 2007-05-17  1:52 UTC (permalink / raw)
  To: htejun, chrisw, jeff, jeroen.janssen, linux-ide; +Cc: stable


This is a note to let you know that we have just queued up the patch titled

     Subject: sata_via: add missing PM hooks

to the 2.6.21-stable tree.  Its filename is

     sata_via-add-missing-pm-hooks.patch

A git repo of this tree can be found at 
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary


>From stable-bounces@linux.kernel.org  Fri May  4 06:32:42 2007
Message-ID: <463B357A.4090703@gmail.com>
Date: Fri, 04 May 2007 15:30:34 +0200
From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>, IDE/ATA development list <linux-ide@vger.kernel.org>, stable@kernel.org
Cc: Jeroen Janssen <jeroen.janssen@gmail.com>
Subject: sata_via: add missing PM hooks

For some reason, sata_via is missing PM hooks.  Add them.  Spotted by
Jeroen Janssen <jeroen.janssen@gmail.com>.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Jeroen Janssen <jeroen.janssen@gmail.com>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
---
 drivers/ata/sata_via.c |    8 ++++++++
 1 file changed, 8 insertions(+)

--- linux-2.6.21.1.orig/drivers/ata/sata_via.c
+++ linux-2.6.21.1/drivers/ata/sata_via.c
@@ -97,6 +97,10 @@ static struct pci_driver svia_pci_driver
 	.name			= DRV_NAME,
 	.id_table		= svia_pci_tbl,
 	.probe			= svia_init_one,
+#ifdef CONFIG_PM
+	.suspend		= ata_pci_device_suspend,
+	.resume			= ata_pci_device_resume,
+#endif
 	.remove			= ata_pci_remove_one,
 };
 
@@ -116,6 +120,10 @@ static struct scsi_host_template svia_sh
 	.slave_configure	= ata_scsi_slave_config,
 	.slave_destroy		= ata_scsi_slave_destroy,
 	.bios_param		= ata_std_bios_param,
+#ifdef CONFIG_PM
+	.suspend		= ata_scsi_device_suspend,
+	.resume			= ata_scsi_device_resume,
+#endif
 };
 
 static const struct ata_port_operations vt6420_sata_ops = {


Patches currently in stable-queue which might be from htejun@gmail.com are

queue-2.6.21/driver-core-don-t-free-devt_attr-till-the-device-is-released.patch
queue-2.6.21/libata-sff-undo-bug-introduced-with-pci_iomap-changes.patch
queue-2.6.21/pci-quirks-disable-msi-on-rs400-200-and-rs480.patch
queue-2.6.21/sata_via-add-missing-pm-hooks.patch

^ permalink raw reply	[flat|nested] 8+ messages in thread

* VIA VT6420 SATA suspend/resume problem in 2.6.20?
@ 2007-05-03 12:42 Jeroen Janssen
  2007-05-03 14:45 ` Tejun Heo
  0 siblings, 1 reply; 8+ messages in thread
From: Jeroen Janssen @ 2007-05-03 12:42 UTC (permalink / raw)
  To: linux-ide

Hello,

I have a board with a VIA 6420 chipset and a SATA harddisk running on
2.6.20 (Fedora Core 6).

When I suspend the system, it goes to sleep instantly, but when I
wakeup the system, it takes about 2 x 30 seconds for the SATA disk to
be accessable again.

I searched the mailinglist and could not really find if this is a
known problem (although I noticed that there's some work going on in
the acpi power management).

Does anyone if this is a known problem? (and if so, is there a
solution available?)
How can I pinpoint the exact problem?

If you need any specific logging, just let me know and I'll provide them.

Best regards,

Jeroen Janssen

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: VIA VT6420 SATA suspend/resume problem in 2.6.20?
  2007-05-03 12:42 VIA VT6420 SATA suspend/resume problem in 2.6.20? Jeroen Janssen
@ 2007-05-03 14:45 ` Tejun Heo
  2007-05-04  8:22   ` Jeroen Janssen
  0 siblings, 1 reply; 8+ messages in thread
From: Tejun Heo @ 2007-05-03 14:45 UTC (permalink / raw)
  To: Jeroen Janssen; +Cc: linux-ide

Jeroen Janssen wrote:
> Hello,
> 
> I have a board with a VIA 6420 chipset and a SATA harddisk running on
> 2.6.20 (Fedora Core 6).
> 
> When I suspend the system, it goes to sleep instantly, but when I
> wakeup the system, it takes about 2 x 30 seconds for the SATA disk to
> be accessable again.
> 
> I searched the mailinglist and could not really find if this is a
> known problem (although I noticed that there's some work going on in
> the acpi power management).
> 
> Does anyone if this is a known problem? (and if so, is there a
> solution available?)
> How can I pinpoint the exact problem?
> 
> If you need any specific logging, just let me know and I'll provide them.

The result of dmesg after resume would be nice.

-- 
tejun

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: VIA VT6420 SATA suspend/resume problem in 2.6.20?
  2007-05-03 14:45 ` Tejun Heo
@ 2007-05-04  8:22   ` Jeroen Janssen
  2007-05-04  9:03     ` [PATCH] sata_via: add missing PM hooks Tejun Heo
  0 siblings, 1 reply; 8+ messages in thread
From: Jeroen Janssen @ 2007-05-04  8:22 UTC (permalink / raw)
  To: Tejun Heo; +Cc: linux-ide

[-- Attachment #1: Type: text/plain, Size: 964 bytes --]

Hi,

Attached is the output from dmesg. Let me know if you need anything
else to pinpoint the problem!

Best regards,

Jeroen Janssen

On 5/3/07, Tejun Heo <htejun@gmail.com> wrote:
> Jeroen Janssen wrote:
> > Hello,
> >
> > I have a board with a VIA 6420 chipset and a SATA harddisk running on
> > 2.6.20 (Fedora Core 6).
> >
> > When I suspend the system, it goes to sleep instantly, but when I
> > wakeup the system, it takes about 2 x 30 seconds for the SATA disk to
> > be accessable again.
> >
> > I searched the mailinglist and could not really find if this is a
> > known problem (although I noticed that there's some work going on in
> > the acpi power management).
> >
> > Does anyone if this is a known problem? (and if so, is there a
> > solution available?)
> > How can I pinpoint the exact problem?
> >
> > If you need any specific logging, just let me know and I'll provide them.
>
> The result of dmesg after resume would be nice.
>
> --
> tejun
>

[-- Attachment #2: dmesg.log --]
[-- Type: application/octet-stream, Size: 19833 bytes --]

Linux version 2.6.20-1.2948.fc6 (brewbuilder@hs20-bc1-6.build.redhat.com) (gcc version 4.1.1 20070105 (Red Hat 4.1.1-51)) #1 SMP Fri Apr 27 18:53:15 EDT 2007
BIOS-provided physical RAM map:
sanitize start
sanitize end
copy_e820_map() start: 0000000000000000 size: 000000000009f800 end: 000000000009f800 type: 1
copy_e820_map() type is E820_RAM
copy_e820_map() start: 000000000009f800 size: 0000000000000800 end: 00000000000a0000 type: 2
copy_e820_map() start: 00000000000f0000 size: 0000000000010000 end: 0000000000100000 type: 2
copy_e820_map() start: 0000000000100000 size: 000000001ede0000 end: 000000001eee0000 type: 1
copy_e820_map() type is E820_RAM
copy_e820_map() start: 000000001eee0000 size: 0000000000003000 end: 000000001eee3000 type: 4
copy_e820_map() start: 000000001eee3000 size: 000000000000d000 end: 000000001eef0000 type: 3
copy_e820_map() start: 000000001eef0000 size: 0000000000010000 end: 000000001ef00000 type: 2
copy_e820_map() start: 00000000fec00000 size: 0000000000001000 end: 00000000fec01000 type: 2
copy_e820_map() start: 00000000fee00000 size: 0000000000001000 end: 00000000fee01000 type: 2
copy_e820_map() start: 00000000ffff0000 size: 0000000000010000 end: 0000000100000000 type: 2
 BIOS-e820: 0000000000000000 - 000000000009f800 (usable)
 BIOS-e820: 000000000009f800 - 00000000000a0000 (reserved)
 BIOS-e820: 00000000000f0000 - 0000000000100000 (reserved)
 BIOS-e820: 0000000000100000 - 000000001eee0000 (usable)
 BIOS-e820: 000000001eee0000 - 000000001eee3000 (ACPI NVS)
 BIOS-e820: 000000001eee3000 - 000000001eef0000 (ACPI data)
 BIOS-e820: 000000001eef0000 - 000000001ef00000 (reserved)
 BIOS-e820: 00000000fec00000 - 00000000fec01000 (reserved)
 BIOS-e820: 00000000fee00000 - 00000000fee01000 (reserved)
 BIOS-e820: 00000000ffff0000 - 0000000100000000 (reserved)
0MB HIGHMEM available.
494MB LOWMEM available.
found SMP MP-table at 000f3540
Using x86 segment limits to approximate NX protection
Entering add_active_range(0, 0, 126688) 0 entries of 256 used
Zone PFN ranges:
  DMA             0 ->     4096
  Normal       4096 ->   126688
  HighMem    126688 ->   126688
early_node_map[1] active PFN ranges
    0:        0 ->   126688
On node 0 totalpages: 126688
  DMA zone: 40 pages used for memmap
  DMA zone: 0 pages reserved
  DMA zone: 4056 pages, LIFO batch:0
  Normal zone: 1197 pages used for memmap
  Normal zone: 121395 pages, LIFO batch:31
  HighMem zone: 0 pages used for memmap
DMI 2.3 present.
Using APIC driver default
ACPI: RSDP (v000 CN700                                 ) @ 0x000f76a0
ACPI: RSDT (v001 CN700  AWRDACPI 0x42302e31 AWRD 0x00000000) @ 0x1eee3040
ACPI: FADT (v001 CN700  AWRDACPI 0x42302e31 AWRD 0x00000000) @ 0x1eee30c0
ACPI: MADT (v001 CN700  AWRDACPI 0x42302e31 AWRD 0x00000000) @ 0x1eee7f40
ACPI: DSDT (v001 CN700  AWRDACPI 0x00001000 MSFT 0x0100000e) @ 0x00000000
ACPI: PM-Timer IO Port: 0x408
ACPI: Local APIC address 0xfee00000
ACPI: LAPIC (acpi_id[0x00] lapic_id[0x00] enabled)
Processor #0 6:10 APIC version 20
ACPI: LAPIC_NMI (acpi_id[0x00] high edge lint[0x1])
ACPI: IOAPIC (id[0x02] address[0xfec00000] gsi_base[0])
IOAPIC[0]: apic_id 2, version 3, address 0xfec00000, GSI 0-23
ACPI: INT_SRC_OVR (bus 0 bus_irq 0 global_irq 2 dfl dfl)
ACPI: INT_SRC_OVR (bus 0 bus_irq 9 global_irq 9 low level)
ACPI: IRQ0 used by override.
ACPI: IRQ2 used by override.
ACPI: IRQ9 used by override.
Enabling APIC mode:  Flat.  Using 1 I/O APICs
Using ACPI (MADT) for SMP configuration information
Allocating PCI resources starting at 20000000 (gap: 1ef00000:dfd00000)
Detected 1496.331 MHz processor.
Built 1 zonelists.  Total pages: 125451
Kernel command line: ro root=LABEL=/1 rhgb quiet
mapped APIC to ffffd000 (fee00000)
mapped IOAPIC to ffffc000 (fec00000)
Enabling fast FPU save and restore... done.
Enabling unmasked SIMD FPU exception support... done.
Initializing CPU#0
CPU 0 irqstacks, hard=c079a000 soft=c077a000
PID hash table entries: 2048 (order: 11, 8192 bytes)
Console: colour VGA+ 80x25
Dentry cache hash table entries: 65536 (order: 6, 262144 bytes)
Inode-cache hash table entries: 32768 (order: 5, 131072 bytes)
Memory: 494976k/506752k available (2156k kernel code, 11184k reserved, 1128k data, 232k init, 0k highmem)
virtual kernel memory layout:
    fixmap  : 0xffc55000 - 0xfffff000   (3752 kB)
    pkmap   : 0xff800000 - 0xffc00000   (4096 kB)
    vmalloc : 0xdf800000 - 0xff7fe000   ( 511 MB)
    lowmem  : 0xc0000000 - 0xdeee0000   ( 494 MB)
      .init : 0xc073b000 - 0xc0775000   ( 232 kB)
      .data : 0xc061b2a9 - 0xc0735494   (1128 kB)
      .text : 0xc0400000 - 0xc061b2a9   (2156 kB)
Checking if this processor honours the WP bit even in supervisor mode... Ok.
Calibrating delay using timer specific routine.. 2994.84 BogoMIPS (lpj=1497420)
Security Framework v1.0.0 initialized
SELinux:  Initializing.
SELinux:  Starting in permissive mode
selinux_register_security:  Registering secondary module capability
Capability LSM initialized as secondary
Mount-cache hash table entries: 512
CPU: After generic identify, caps: a7c9baff 00100000 00000000 00000000 00000181 00000000 00000000
CPU: L1 I Cache: 64K (64 bytes/line), D cache 64K (64 bytes/line)
CPU: L2 Cache: 128K (64 bytes/line)
CPU: After all inits, caps: 27c9b2ff 00100000 00000000 00000000 00000181 00003fcc 00000000
Checking 'hlt' instruction... OK.
SMP alternatives: switching to UP code
Freeing SMP alternatives: 12k freed
ACPI: Core revision 20060707
CPU0: Centaur VIA Esther processor 1500MHz stepping 09
Total of 1 processors activated (2994.84 BogoMIPS).
ENABLING IO-APIC IRQs
..TIMER: vector=0x31 apic1=0 pin1=2 apic2=-1 pin2=-1
Brought up 1 CPUs
sizeof(vma)=84 bytes
sizeof(page)=40 bytes
sizeof(inode)=420 bytes
sizeof(dentry)=144 bytes
sizeof(ext3inode)=596 bytes
sizeof(buffer_head)=56 bytes
sizeof(skbuff)=176 bytes
sizeof(task_struct)=1408 bytes
NET: Registered protocol family 16
ACPI: bus type pci registered
PCI: PCI BIOS revision 2.10 entry at 0xf9f20, last bus=1
PCI: Using configuration type 1
Setting up standard PCI resources
ACPI: Interpreter enabled
ACPI: Using IOAPIC for interrupt routing
ACPI: PCI Root Bridge [PCI0] (0000:00)
PCI: Probing PCI hardware (bus 00)
0000:00:0f.1: cannot adjust BAR0 (not I/O)
0000:00:0f.1: cannot adjust BAR1 (not I/O)
0000:00:0f.1: cannot adjust BAR2 (not I/O)
0000:00:0f.1: cannot adjust BAR3 (not I/O)
Boot video device is 0000:01:00.0
ACPI: PCI Interrupt Routing Table [\_SB_.PCI0._PRT]
ACPI: PCI Interrupt Link [LNKA] (IRQs 3 4 6 *7 10 11 12)
ACPI: PCI Interrupt Link [LNKB] (IRQs 3 4 6 7 10 11 12) *5
ACPI: PCI Interrupt Link [LNKC] (IRQs *3 4 6 7 10 11 12)
ACPI: PCI Interrupt Link [LNKD] (IRQs 3 4 6 7 10 11 12) *0, disabled.
ACPI: PCI Interrupt Link [LNKE] (IRQs 3 4 6 7 10 11 12) *0, disabled.
ACPI: PCI Interrupt Link [LNKF] (IRQs 3 4 6 7 10 11 12) *0, disabled.
ACPI: PCI Interrupt Link [LNK0] (IRQs 3 4 6 7 10 11 12) *0, disabled.
ACPI: PCI Interrupt Link [LNK1] (IRQs 3 4 6 7 10 11 12) *0, disabled.
ACPI: PCI Interrupt Link [ALKA] (IRQs *20)
ACPI: PCI Interrupt Link [ALKB] (IRQs *21)
ACPI: PCI Interrupt Link [ALKC] (IRQs *22), disabled.
ACPI: PCI Interrupt Link [ALKD] (IRQs *23)
Linux Plug and Play Support v0.97 (c) Adam Belay
pnp: PnP ACPI init
pnp: PnP ACPI: found 14 devices
usbcore: registered new interface driver usbfs
usbcore: registered new interface driver hub
usbcore: registered new device driver usb
PCI: Using ACPI for IRQ routing
PCI: If a device doesn't work, try "pci=routeirq".  If it helps, post a report
NetLabel: Initializing
NetLabel:  domain hash size = 128
NetLabel:  protocols = UNLABELED CIPSOv4
NetLabel:  unlabeled traffic allowed by default
pnp: 00:02: ioport range 0x400-0x47f could not be reserved
pnp: 00:02: ioport range 0x500-0x50f has been reserved
PCI: Bridge: 0000:00:01.0
  IO window: disabled.
  MEM window: fa000000-fbffffff
  PREFETCH window: f4000000-f7ffffff
PCI: Setting latency timer of device 0000:00:01.0 to 64
NET: Registered protocol family 2
IP route cache hash table entries: 4096 (order: 2, 16384 bytes)
TCP established hash table entries: 16384 (order: 6, 327680 bytes)
TCP bind hash table entries: 8192 (order: 5, 163840 bytes)
TCP: Hash tables configured (established 16384 bind 8192)
TCP reno registered
checking if image is initramfs... it is
Freeing initrd memory: 1484k freed
apm: BIOS version 1.2 Flags 0x07 (Driver version 1.16ac)
apm: overridden by ACPI.
audit: initializing netlink socket (disabled)
audit(1178272103.845:1): initialized
Total HugeTLB memory allocated, 0
VFS: Disk quotas dquot_6.5.1
Dquot-cache hash table entries: 1024 (order 0, 4096 bytes)
SELinux:  Registering netfilter hooks
ksign: Installing public key data
Loading keyring
- Added public key D8906D8AE5DBA77
- User ID: Red Hat, Inc. (Kernel Module GPG key)
io scheduler noop registered
io scheduler anticipatory registered
io scheduler deadline registered
io scheduler cfq registered (default)
0000:00:10.4 EHCI: BIOS handoff failed (BIOS bug ?) 01010001
PCI: Bypassing VIA 8237 APIC De-Assert Message
ACPI: Fan [FAN] (on)
ACPI: CPU0 (power states: C1[C1] C2[C2] C3[C3])
ACPI: Processor [CPU0] (supports 2 throttling states)
ACPI: Thermal Zone [THRM] (27 C)
isapnp: Scanning for PnP cards...
isapnp: No Plug & Play device found
Real Time Clock Driver v1.12ac
Non-volatile memory driver v1.2
Linux agpgart interface v0.101 (c) Dave Jones
agpgart: Detected VIA VT3314 chipset
agpgart: AGP aperture is 32M @ 0xf8000000
Serial: 8250/16550 driver $Revision: 1.90 $ 4 ports, IRQ sharing enabled
serial8250: ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A
serial8250: ttyS2 at I/O 0x3e8 (irq = 11) is a 16550A
serial8250: ttyS3 at I/O 0x2e8 (irq = 10) is a 16550A
00:09: ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A
00:0c: ttyS2 at I/O 0x3e8 (irq = 11) is a 16550A
00:0d: ttyS3 at I/O 0x2e8 (irq = 10) is a 16550A
RAMDISK driver initialized: 16 RAM disks of 16384K size 4096 blocksize
input: Macintosh mouse button emulation as /class/input/input0
Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2
ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
VP_IDE: IDE controller at PCI slot 0000:00:0f.1
ACPI: PCI Interrupt Link [ALKA] enabled at IRQ 20
ACPI: PCI Interrupt 0000:00:0f.1[A] -> Link [ALKA] -> GSI 20 (level, low) -> IRQ 16
VP_IDE: chipset revision 6
VP_IDE: not 100% native mode: will probe irqs later
VP_IDE: VIA vt8237 (rev 00) IDE UDMA133 controller on pci0000:00:0f.1
    ide0: BM-DMA at 0xdc00-0xdc07, BIOS settings: hda:pio, hdb:pio
    ide1: BM-DMA at 0xdc08-0xdc0f, BIOS settings: hdc:pio, hdd:pio
Probing IDE interface ide0...
Probing IDE interface ide1...
Probing IDE interface ide0...
Probing IDE interface ide1...
ide-floppy driver 0.99.newide
usbcore: registered new interface driver libusual
usbcore: registered new interface driver hiddev
usbcore: registered new interface driver usbhid
drivers/usb/input/hid-core.c: v2.6:USB HID core driver
PNP: PS/2 Controller [PNP0303:PS2K,PNP0f13:PS2M] at 0x60,0x64 irq 1,12
serio: i8042 KBD port at 0x60,0x64 irq 1
serio: i8042 AUX port at 0x60,0x64 irq 12
mice: PS/2 mouse device common for all mice
input: AT Translated Set 2 keyboard as /class/input/input1
TCP bic registered
Initializing XFRM netlink socket
NET: Registered protocol family 1
NET: Registered protocol family 17
Using IPI No-Shortcut mode
ACPI: (supports S0 S3 S4 S5)
Time: tsc clocksource has been installed.
Freeing unused kernel memory: 232k freed
Write protecting the kernel read-only data: 819k
Time: acpi_pm clocksource has been installed.
firmware_class: attempt to set timeout to 10
input: ImPS/2 Generic Wheel Mouse as /class/input/input2
USB Universal Host Controller Interface driver v3.0
ACPI: PCI Interrupt Link [ALKB] enabled at IRQ 21
ACPI: PCI Interrupt 0000:00:10.0[A] -> Link [ALKB] -> GSI 21 (level, low) -> IRQ 17
uhci_hcd 0000:00:10.0: UHCI Host Controller
uhci_hcd 0000:00:10.0: new USB bus registered, assigned bus number 1
uhci_hcd 0000:00:10.0: irq 17, io base 0x0000dd00
usb usb1: configuration #1 chosen from 1 choice
hub 1-0:1.0: USB hub found
hub 1-0:1.0: 2 ports detected
ACPI: PCI Interrupt 0000:00:10.1[A] -> Link [ALKB] -> GSI 21 (level, low) -> IRQ 17
uhci_hcd 0000:00:10.1: UHCI Host Controller
uhci_hcd 0000:00:10.1: new USB bus registered, assigned bus number 2
uhci_hcd 0000:00:10.1: irq 17, io base 0x0000de00
usb usb2: configuration #1 chosen from 1 choice
hub 2-0:1.0: USB hub found
hub 2-0:1.0: 2 ports detected
ACPI: PCI Interrupt 0000:00:10.2[B] -> Link [ALKB] -> GSI 21 (level, low) -> IRQ 17
uhci_hcd 0000:00:10.2: UHCI Host Controller
uhci_hcd 0000:00:10.2: new USB bus registered, assigned bus number 3
uhci_hcd 0000:00:10.2: irq 17, io base 0x0000df00
usb usb3: configuration #1 chosen from 1 choice
hub 3-0:1.0: USB hub found
hub 3-0:1.0: 2 ports detected
PCI: Enabling device 0000:00:10.3 (0000 -> 0001)
ACPI: PCI Interrupt 0000:00:10.3[B] -> Link [ALKB] -> GSI 21 (level, low) -> IRQ 17
uhci_hcd 0000:00:10.3: UHCI Host Controller
uhci_hcd 0000:00:10.3: new USB bus registered, assigned bus number 4
uhci_hcd 0000:00:10.3: irq 17, io base 0x00001000
usb usb4: configuration #1 chosen from 1 choice
hub 4-0:1.0: USB hub found
hub 4-0:1.0: 2 ports detected
ohci_hcd: 2006 August 04 USB 1.1 'Open' Host Controller (OHCI) Driver (PCI)
ACPI: PCI Interrupt 0000:00:10.4[C] -> Link [ALKB] -> GSI 21 (level, low) -> IRQ 17
ehci_hcd 0000:00:10.4: EHCI Host Controller
ehci_hcd 0000:00:10.4: new USB bus registered, assigned bus number 5
ehci_hcd 0000:00:10.4: irq 17, io mem 0xfc000000
ehci_hcd 0000:00:10.4: USB 2.0 started, EHCI 1.00, driver 10 Dec 2004
usb usb5: configuration #1 chosen from 1 choice
hub 5-0:1.0: USB hub found
hub 5-0:1.0: 8 ports detected
SCSI subsystem initialized
libata version 2.00 loaded.
sata_via 0000:00:0f.0: version 2.0
ACPI: PCI Interrupt 0000:00:0f.0[B] -> Link [ALKA] -> GSI 20 (level, low) -> IRQ 16
sata_via 0000:00:0f.0: routed to hard irq line 5
ata1: SATA max UDMA/133 cmd 0xDB00 ctl 0xE102 bmdma 0xDA00 irq 16
ata2: SATA max UDMA/133 cmd 0xD800 ctl 0xD902 bmdma 0xDA08 irq 16
scsi0 : sata_via
ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300)
ATA: abnormal status 0x7F on port 0xDB07
ATA: abnormal status 0x7F on port 0xDB07
ata1.00: ATA-7, max UDMA/133, 156301488 sectors: LBA48 NCQ (depth 0/32)
ata1.00: ata1: dev 0 multi count 16
ata1.00: configured for UDMA/133
scsi1 : sata_via
ata2: SATA link down 1.5 Gbps (SStatus 0 SControl 300)
ATA: abnormal status 0x7F on port 0xD807
scsi 0:0:0:0: Direct-Access     ATA      ST380811AS       3.AA PQ: 0 ANSI: 5
SCSI device sda: 156301488 512-byte hdwr sectors (80026 MB)
sda: Write Protect is off
sda: Mode Sense: 00 3a 00 00
SCSI device sda: write cache: enabled, read cache: enabled, doesn't support DPO or FUA
SCSI device sda: 156301488 512-byte hdwr sectors (80026 MB)
sda: Write Protect is off
sda: Mode Sense: 00 3a 00 00
SCSI device sda: write cache: enabled, read cache: enabled, doesn't support DPO or FUA
 sda: sda1 sda2 sda3 sda4 < sda5 >
sd 0:0:0:0: Attached scsi disk sda
kjournald starting.  Commit interval 5 seconds
EXT3-fs: mounted filesystem with ordered data mode.
SELinux:  Disabled at runtime.
SELinux:  Unregistering netfilter hooks
audit(1178272116.139:2): selinux=0 auid=4294967295
via-rhine.c:v1.10-LK1.4.2 Sept-11-2006 Written by Donald Becker
ACPI: PCI Interrupt Link [ALKD] enabled at IRQ 23
ACPI: PCI Interrupt 0000:00:12.0[A] -> Link [ALKD] -> GSI 23 (level, low) -> IRQ 18
eth0: VIA Rhine II at 0xfc001000, 00:03:2d:07:af:3d, IRQ 18.
eth0: MII PHY found at address 1, status 0x7849 advertising 05e1 Link 0000.
input: PC Speaker as /class/input/input3
sd 0:0:0:0: Attached scsi generic sg0 type 0
Floppy drive(s): fd0 is 1.44M
FDC 0 is a post-1991 82077
lp: driver loaded but no devices found
sonypi: Sony Programmable I/O Controller Driver v1.26.
input: Power Button (FF) as /class/input/input4
ACPI: Power Button (FF) [PWRF]
input: Power Button (CM) as /class/input/input5
ACPI: Power Button (CM) [PWRB]
No dock devices found.
md: Autodetecting RAID arrays.
md: autorun ...
md: ... autorun DONE.
device-mapper: ioctl: 4.11.0-ioctl (2006-10-12) initialised: dm-devel@redhat.com
device-mapper: multipath: version 1.0.5 loaded
EXT3 FS on sda1, internal journal
kjournald starting.  Commit interval 5 seconds
EXT3 FS on sda2, internal journal
EXT3-fs: mounted filesystem with ordered data mode.
kjournald starting.  Commit interval 5 seconds
EXT3 FS on sda5, internal journal
EXT3-fs: mounted filesystem with ordered data mode.
Adding 1012084k swap on /dev/sda3.  Priority:-1 extents:1 across:1012084k
NET: Registered protocol family 10
lo: Disabled Privacy Extensions
Mobile IPv6
eth0: link down
ADDRCONF(NETDEV_UP): eth0: link is not ready
Bluetooth: Core ver 2.11
NET: Registered protocol family 31
Bluetooth: HCI device and connection manager initialized
Bluetooth: HCI socket layer initialized
Bluetooth: L2CAP ver 2.8
Bluetooth: L2CAP socket layer initialized
Bluetooth: RFCOMM socket layer initialized
Bluetooth: RFCOMM TTY layer initialized
Bluetooth: RFCOMM ver 1.8
Bluetooth: HIDP (Human Interface Emulation) ver 1.1
tkusb: disagrees about version of symbol struct_module
[drm] Initialized drm 1.1.0 20060810
ACPI: PCI Interrupt 0000:01:00.0[A] -> GSI 16 (level, low) -> IRQ 19
[drm] Initialized via 2.10.0 20060529 on minor 0
agpgart: Found an AGP 3.5 compliant device at 0000:00:00.0.
agpgart: Putting AGP V3 device at 0000:00:00.0 into 8x mode
agpgart: Putting AGP V3 device at 0000:01:00.0 into 8x mode
Disabling non-boot CPUs ...
Stopping tasks ... done.
Suspending console(s)
pnp: Device 00:0d disabled.
pnp: Device 00:0c disabled.
pnp: Device 00:09 disabled.
ACPI: PCI interrupt for device 0000:00:10.4 disabled
ACPI: PCI interrupt for device 0000:00:10.3 disabled
ACPI: PCI interrupt for device 0000:00:10.2 disabled
ACPI: PCI interrupt for device 0000:00:10.1 disabled
ACPI: PCI interrupt for device 0000:00:10.0 disabled
pci_set_power_state(): 0000:00:00.0: state=3, current state=5
Back to C!
ACPI: Unable to turn cooling device [c1560e8c] 'on'
PM: Writing back config space on device 0000:00:00.0 at offset 1 (was 22300006, writing a2300006)
PCI: Setting latency timer of device 0000:00:01.0 to 64
ACPI: PCI Interrupt 0000:00:0f.0[B] -> Link [ALKA] -> GSI 20 (level, low) -> IRQ 16
ACPI: PCI Interrupt 0000:00:0f.1[A] -> Link [ALKA] -> GSI 20 (level, low) -> IRQ 16
ACPI: PCI Interrupt 0000:00:10.0[A] -> Link [ALKB] -> GSI 21 (level, low) -> IRQ 17
usb usb1: root hub lost power or was reset
ACPI: PCI Interrupt 0000:00:10.1[A] -> Link [ALKB] -> GSI 21 (level, low) -> IRQ 17
usb usb2: root hub lost power or was reset
ACPI: PCI Interrupt 0000:00:10.2[B] -> Link [ALKB] -> GSI 21 (level, low) -> IRQ 17
usb usb3: root hub lost power or was reset
ACPI: PCI Interrupt 0000:00:10.3[B] -> Link [ALKB] -> GSI 21 (level, low) -> IRQ 17
usb usb4: root hub lost power or was reset
ACPI: PCI Interrupt 0000:00:10.4[C] -> Link [ALKB] -> GSI 21 (level, low) -> IRQ 17
ACPI: PCI Interrupt 0000:01:00.0[A] -> GSI 16 (level, low) -> IRQ 19
pnp: Device 00:09 activated.
pnp: Failed to activate device 00:0a.
pnp: Failed to activate device 00:0b.
pnp: Device 00:0c activated.
pnp: Device 00:0d activated.
Restarting tasks ... done.
Enabling non-boot CPUs ...
ATA: abnormal status 0x80 on port 0xDB07
ATA: abnormal status 0x80 on port 0xDB07
ATA: abnormal status 0x80 on port 0xDB07
ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata1.00: cmd ca/00:08:47:28:50/00:00:00:00:00/e0 tag 0 cdb 0x0 data 4096 out
         res 40/00:01:00:4f:c2/00:00:00:00:00/00 Emask 0x4 (timeout)
ata1: soft resetting port
ATA: abnormal status 0x7F on port 0xDB07
ATA: abnormal status 0x7F on port 0xDB07
ata1.00: configured for UDMA/133
ata1: EH complete
SCSI device sda: 156301488 512-byte hdwr sectors (80026 MB)
sda: Write Protect is off
sda: Mode Sense: 00 3a 00 00
SCSI device sda: write cache: enabled, read cache: enabled, doesn't support DPO or FUA

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] sata_via: add missing PM hooks
  2007-05-04  8:22   ` Jeroen Janssen
@ 2007-05-04  9:03     ` Tejun Heo
  2007-05-04 13:21       ` Jeroen Janssen
  0 siblings, 1 reply; 8+ messages in thread
From: Tejun Heo @ 2007-05-04  9:03 UTC (permalink / raw)
  To: Jeroen Janssen; +Cc: linux-ide

For some reason, sata_via is missing PM hooks.  Add them.

Signed-off-by: Tejun Heo <htejun@gmail.com>
---
This patch is against 2.6.21 but you can use it over 2.6.20 too.  Does
this fix your problem?

Index: tree0/drivers/ata/sata_via.c
===================================================================
--- tree0.orig/drivers/ata/sata_via.c
+++ tree0/drivers/ata/sata_via.c
@@ -97,6 +97,10 @@ static struct pci_driver svia_pci_driver
 	.name			= DRV_NAME,
 	.id_table		= svia_pci_tbl,
 	.probe			= svia_init_one,
+#ifdef CONFIG_PM
+	.suspend		= ata_pci_device_suspend,
+	.resume			= ata_pci_device_resume,
+#endif
 	.remove			= ata_pci_remove_one,
 };
 
@@ -116,6 +120,10 @@ static struct scsi_host_template svia_sh
 	.slave_configure	= ata_scsi_slave_config,
 	.slave_destroy		= ata_scsi_slave_destroy,
 	.bios_param		= ata_std_bios_param,
+#ifdef CONFIG_PM
+	.suspend		= ata_scsi_device_suspend,
+	.resume			= ata_scsi_device_resume,
+#endif
 };
 
 static const struct ata_port_operations vt6420_sata_ops = {

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] sata_via: add missing PM hooks
  2007-05-04  9:03     ` [PATCH] sata_via: add missing PM hooks Tejun Heo
@ 2007-05-04 13:21       ` Jeroen Janssen
  2007-05-04 13:25         ` Tejun Heo
  0 siblings, 1 reply; 8+ messages in thread
From: Jeroen Janssen @ 2007-05-04 13:21 UTC (permalink / raw)
  To: Tejun Heo; +Cc: linux-ide

Hi,

Thanks very much! This indeed solved the problem.
Anything I can to help get it included in the next kernel release?

Best regards,

Jeroen Janssen

On 5/4/07, Tejun Heo <htejun@gmail.com> wrote:
> For some reason, sata_via is missing PM hooks.  Add them.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> This patch is against 2.6.21 but you can use it over 2.6.20 too.  Does
> this fix your problem?
>
> Index: tree0/drivers/ata/sata_via.c
> ===================================================================
> --- tree0.orig/drivers/ata/sata_via.c
> +++ tree0/drivers/ata/sata_via.c
> @@ -97,6 +97,10 @@ static struct pci_driver svia_pci_driver
>         .name                   = DRV_NAME,
>         .id_table               = svia_pci_tbl,
>         .probe                  = svia_init_one,
> +#ifdef CONFIG_PM
> +       .suspend                = ata_pci_device_suspend,
> +       .resume                 = ata_pci_device_resume,
> +#endif
>         .remove                 = ata_pci_remove_one,
>  };
>
> @@ -116,6 +120,10 @@ static struct scsi_host_template svia_sh
>         .slave_configure        = ata_scsi_slave_config,
>         .slave_destroy          = ata_scsi_slave_destroy,
>         .bios_param             = ata_std_bios_param,
> +#ifdef CONFIG_PM
> +       .suspend                = ata_scsi_device_suspend,
> +       .resume                 = ata_scsi_device_resume,
> +#endif
>  };
>
>  static const struct ata_port_operations vt6420_sata_ops = {
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] sata_via: add missing PM hooks
  2007-05-04 13:21       ` Jeroen Janssen
@ 2007-05-04 13:25         ` Tejun Heo
  0 siblings, 0 replies; 8+ messages in thread
From: Tejun Heo @ 2007-05-04 13:25 UTC (permalink / raw)
  To: Jeroen Janssen; +Cc: linux-ide

Jeroen Janssen wrote:
> Hi,
> 
> Thanks very much! This indeed solved the problem.
> Anything I can to help get it included in the next kernel release?

Well, the mystery here is how this bit was missing so there should be no
problem including it in the next release.  I'll forward it to -stable
team too.  It's also a bit amusing to see libata EH actually recovers
from suspend without explicit resuming.  :-)

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2007-05-17  1:54 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-04 13:30 [PATCH] sata_via: add missing PM hooks Tejun Heo
2007-05-08  9:54 ` Jeroen Janssen
2007-05-08 10:27   ` Tejun Heo
2007-05-10  0:17 ` Jeff Garzik
2007-05-17  1:52 ` patch sata_via-add-missing-pm-hooks.patch queued to 2.6.21-stable tree chrisw
  -- strict thread matches above, loose matches on Subject: below --
2007-05-03 12:42 VIA VT6420 SATA suspend/resume problem in 2.6.20? Jeroen Janssen
2007-05-03 14:45 ` Tejun Heo
2007-05-04  8:22   ` Jeroen Janssen
2007-05-04  9:03     ` [PATCH] sata_via: add missing PM hooks Tejun Heo
2007-05-04 13:21       ` Jeroen Janssen
2007-05-04 13:25         ` Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).