From: Tejun Heo <htejun@gmail.com>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: jirislaby@gmail.com, akpm@osdl.org, jgarzik@pobox.com,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@kernel.org
Subject: Re: 2.6.21-mm1: many processes end up in D state
Date: Sat, 05 May 2007 17:30:51 +0200 [thread overview]
Message-ID: <463CA32B.1010505@gmail.com> (raw)
In-Reply-To: <200705041919.l44JJ15g009202@harpo.it.uu.se>
Mikael Pettersson wrote:
>> I.e. no freezing of ports...
>
> Your patch to delete the 'return 1;' on error is correct,
> and makes the code match exactly the behaviour of previous
> versions of sata_promise, except for the additional error
> decoding.
>
> ahci and sata_sil24 do the return in this situation. I don't
> yet understand why they can get away with it while sata_promise
> cannot, but for now the return should be removed.
That's because sata_sil24 and ahci call either ata_port_abort() or
ata_port_freeze() prior to finishing error_intr routine. Both functions
abort all in-flight command and schedule EH.
--
tejun
next prev parent reply other threads:[~2007-05-05 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 19:19 2.6.21-mm1: many processes end up in D state Mikael Pettersson
2007-05-05 15:30 ` Tejun Heo [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-05-05 23:46 Mikael Pettersson
2007-05-07 9:52 ` Jiri Slaby
[not found] <46360DA7.6040003@gmail.com>
[not found] ` <46371128.4060101@gmail.com>
2007-05-04 14:58 ` Jiri Slaby
2007-05-04 15:02 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463CA32B.1010505@gmail.com \
--to=htejun@gmail.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=jirislaby@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).