linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: "Matí­as Alejandro Torres" <torresmat@gmail.com>
Cc: linux-ide@vger.kernel.org, gregkh@suse.de
Subject: Re: SATA SB600 works in 2.6.20.4 but not in 2.6.21-rc5 with irqpoll parameter
Date: Sat, 05 May 2007 19:55:58 +0200	[thread overview]
Message-ID: <463CC52E.8050500@gmail.com> (raw)
In-Reply-To: <463CC22C.20902@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

Matí­as Alejandro Torres wrote:
> May be it disables MSI for some other device/bridge/what ever:

Right, that device gotta be PCI-e or PCI-x bridge and the disk
controller lives in a different bus.  Please apply the attached patch.
This one really should fix the problem.  :-)

-- 
tejun

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 1673 bytes --]

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 3411483..1e3070e 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -1624,18 +1624,20 @@ DECLARE_PCI_FIXUP_RESUME(PCI_VENDOR_ID_N
 			quirk_nvidia_ck804_pcie_aer_ext_cap);
 
 #ifdef CONFIG_PCI_MSI
-/* The Serverworks PCI-X chipset does not support MSI. We cannot easily rely
- * on setting PCI_BUS_FLAGS_NO_MSI in its bus flags because there are actually
- * some other busses controlled by the chipset even if Linux is not aware of it.
- * Instead of setting the flag on all busses in the machine, simply disable MSI
- * globally.
+/* Some chipsets do not support MSI. We cannot easily rely on setting
+ * PCI_BUS_FLAGS_NO_MSI in its bus flags because there are actually
+ * some other busses controlled by the chipset even if Linux is not
+ * aware of it.  Instead of setting the flag on all busses in the
+ * machine, simply disable MSI globally.
  */
-static void __init quirk_svw_msi(struct pci_dev *dev)
+static void __init quirk_disable_all_msi(struct pci_dev *dev)
 {
 	pci_no_msi();
 	printk(KERN_WARNING "PCI: MSI quirk detected. MSI deactivated.\n");
 }
-DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_GCNB_LE, quirk_svw_msi);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_GCNB_LE, quirk_disable_all_msi);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS400_200, quirk_disable_all_msi);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS480, quirk_disable_all_msi);
 
 /* Disable MSI on chipsets that are known to not support it */
 static void __devinit quirk_disable_msi(struct pci_dev *dev)

  reply	other threads:[~2007-05-05 17:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-27  2:25 SATA SB600 Matí­as Alejandro Torres
2007-03-27  2:31 ` Tejun Heo
2007-03-27  2:36   ` Matí­as Alejandro Torres
2007-03-27  2:39     ` Tejun Heo
2007-03-27  4:00       ` SATA SB600 works in 2.6.20.4 but not in 2.6.21-rc5 with irqpoll parameter Matí­as Alejandro Torres
2007-03-27  4:13         ` Tejun Heo
2007-03-27  4:42           ` Matí­as Alejandro Torres
2007-05-04  9:49             ` Tejun Heo
2007-05-04 13:45               ` Matí­as Alejandro Torres
2007-05-04 17:48               ` Matí­as Alejandro Torres
2007-05-04 18:00                 ` Tejun Heo
2007-05-04 19:30                   ` Matí­as Alejandro Torres
2007-05-04 19:36                     ` Tejun Heo
2007-05-05 17:43                       ` Matí­as Alejandro Torres
2007-05-05 17:55                         ` Tejun Heo [this message]
2007-05-07 10:03                           ` Tejun Heo
2007-05-07 15:12                             ` Matí­as Alejandro Torres
2007-05-07 15:35                               ` Tejun Heo
2007-05-07 20:05                                 ` Matí­as Alejandro Torres
2007-05-08  8:07                                   ` Tejun Heo
     [not found]           ` <46089F28.8060803@gmail.com>
2007-03-27  5:02             ` Tejun Heo
2007-04-13  5:26             ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=463CC52E.8050500@gmail.com \
    --to=htejun@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-ide@vger.kernel.org \
    --cc=torresmat@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).