Re: sata_promise - another sata dvd writer problem

Re: sata_promise - another sata dvd writer problem

[Mikael Pettersson]

On Sun, 06 May 2007 16:35:11 +0200, Sven Lemke wrote:
> I'm using kernel 2.6.21-mm1 and get strange problems when connecting
> my new SATA DVD writer to the TX2Plus Promise controller. It works
> with an slightly older kernel version though. And since I couldn't figure
> out who is responsible for the driver I decided to post my problem here.

How much older? Does 2.6.21 vanilla work?

> sata_promise 0000:00:0b.0: version 2.05
> ...
> ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300)
> ata2.00: ATAPI, max UDMA/33
> ata2.00: applying bridge limits
> ata2.00: configured for UDMA/33
> sd 0:0:0:0: [sda] Attached SCSI disk
> sd 0:0:0:0: Attached scsi generic sg0 type 0
> scsi 1:0:0:0: CD-ROM TSSTcorp CD/DVDW SH-S183L SB01 PQ: 0 ANSI: 5
> ...
> ata2.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
> ata2.00: (port_status 0x20200000)
> ata2.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x0 data 0
>          res 40/00:02:00:60:00/00:00:00:00:00/a0 Emask 0x5 (timeout)
etc

Probably fallout from a mistake I made in the error decoding update.
Apply the patch below, try again, and let us know if it works or not.

/Mikael

--- linux-2.6.21-mm1/drivers/ata/sata_promise.c.~1~	2007-05-05 22:24:41.000000000 +0200
+++ linux-2.6.21-mm1/drivers/ata/sata_promise.c	2007-05-05 22:25:21.000000000 +0200
@@ -653,6 +653,8 @@ static void pdc_error_intr(struct ata_po
 	qc->err_mask |= ac_err_mask;
 
 	pdc_reset_port(ap);
+
+	ata_port_abort(ap);
 }
 
 static inline unsigned int pdc_host_intr( struct ata_port *ap,

[SOLVED] Re: sata_promise - another sata dvd writer problem

[Sven Lemke]

Mikael Pettersson wrote:
> On Sun, 06 May 2007 16:35:11 +0200, Sven Lemke wrote:
>
>> sata_promise 0000:00:0b.0: version 2.05
>> ...
>> ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300)
>> ata2.00: ATAPI, max UDMA/33
>> ata2.00: applying bridge limits
>> ata2.00: configured for UDMA/33
>> sd 0:0:0:0: [sda] Attached SCSI disk
>> sd 0:0:0:0: Attached scsi generic sg0 type 0
>> scsi 1:0:0:0: CD-ROM TSSTcorp CD/DVDW SH-S183L SB01 PQ: 0 ANSI: 5
>> ...
>> ata2.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
>> ata2.00: (port_status 0x20200000)
>> ata2.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x0 data 0
>>          res 40/00:02:00:60:00/00:00:00:00:00/a0 Emask 0x5 (timeout)
> etc
>
> Probably fallout from a mistake I made in the error decoding update.
> Apply the patch below, try again, and let us know if it works or not.
>
> /Mikael
>
> --- linux-2.6.21-mm1/drivers/ata/sata_promise.c.~1~	2007-05-05 22:24:41.000000000 +0200
> +++ linux-2.6.21-mm1/drivers/ata/sata_promise.c	2007-05-05 22:25:21.000000000 +0200
> @@ -653,6 +653,8 @@ static void pdc_error_intr(struct ata_po
>  	qc->err_mask |= ac_err_mask;
>  
>  	pdc_reset_port(ap);
> +
> +	ata_port_abort(ap);
>  }
>  
>  static inline unsigned int pdc_host_intr( struct ata_port *ap,
>
This solves the problem. Great job!!

dmesg:
...
ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300)
ata2.00: ATAPI, max UDMA/33
ata2.00: applying bridge limits
ata2.00: configured for UDMA/33
...
scsi 1:0:0:0: CD-ROM TSSTcorp CD/DVDW SH-S183L SB01 PQ: 0 ANSI: 5
...
sr 1:0:0:0: Attached scsi CD-ROM sr0
...


Thanks a lot,
Sven