From: Tejun Heo <htejun@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: albertl@mail.com, albertcc@tw.ibm.com,
Jeff Garzik <jeff@garzik.org>,
Linux IDE <linux-ide@vger.kernel.org>,
Doug Maxey <dwm@enoyolf.org>,
bzolnier@gmail.com, Mark Lord <liml@rtr.ca>
Subject: Re: [PATCH] libata: disable_irq() during polling IDENTIFY (take 2)
Date: Tue, 08 May 2007 14:01:40 +0200 [thread overview]
Message-ID: <464066A4.1010008@gmail.com> (raw)
In-Reply-To: <20070508130025.7693980c@the-village.bc.nu>
Alan Cox wrote:
> On Tue, 08 May 2007 19:30:24 +0800
> Albert Lee <albertcc@tw.ibm.com> wrote:
>
>> Problem:
>> Kernel got "irq 5: nobody cared" when using
>> libata + polling IDENTIFY + Promise 20275 adapter + Benq DW1620 drive.
>>
>> Detail message available in bug 8441 (http://bugzilla.kernel.org/show_bug.cgi?id=8441).
>>
>> Cause:
>> The Benq DW1620 drive raises INTRQ during polling IDENTIFY PACKET DEVICE,
>> even if nIEN = 1.
>>
>> Proposed fix:
>> Ack the possibly unexpected irq in ata_interrupt().
>>
>> Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
>
> NAK
>
> We can't do this. A PIO data transfer could take far far too long to be
> under IRQ block (its already a problem on a big 32bit box when we bounce
> buffer it sometimes).
Oh well, that's how we do PIO data transfer when not polling anyway. We
kick HSM directly from the interrupt handler and do PIO inside the
interrupt handler. The change made here is to make polling PIO act the
same way.
--
tejun
next prev parent reply other threads:[~2007-05-08 12:01 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 4:30 [PATCH] libata: disable_irq() during polling IDENTIFY Albert Lee
2007-05-07 7:43 ` Tejun Heo
2007-05-07 11:18 ` Alan Cox
2007-05-07 11:32 ` Tejun Heo
2007-05-08 13:36 ` Mark Lord
2007-05-07 11:19 ` Albert Lee
2007-05-07 11:29 ` Tejun Heo
2007-05-07 11:54 ` Albert Lee
2007-05-07 12:01 ` Tejun Heo
2007-05-08 11:30 ` [PATCH] libata: disable_irq() during polling IDENTIFY (take 2) Albert Lee
2007-05-08 11:41 ` Tejun Heo
2007-05-08 12:00 ` Alan Cox
2007-05-08 12:01 ` Tejun Heo [this message]
2007-05-08 12:20 ` Alan Cox
2007-05-08 12:27 ` Tejun Heo
2007-05-08 12:43 ` Alan Cox
2007-05-08 12:45 ` Tejun Heo
2007-05-08 12:45 ` Alan Cox
2007-05-08 12:57 ` Tejun Heo
2007-05-08 14:59 ` Albert Lee
2007-05-08 15:16 ` Jeff Garzik
2007-05-11 7:20 ` [PATCH/RFC 0/7] libata: push part of irq driven pio to workqueue Albert Lee
2007-05-11 7:24 ` [PATCH 1/7] libata: set the state after "PIO data-in" to HSM_ST_IDLE instead of HSM_ST_LAST Albert Lee
2007-05-11 7:28 ` [PATCH 2/7] libata: move the ata_altstatus() in ata_hsm_qc_complete() Albert Lee
2007-05-11 7:30 ` [PATCH 3/7] libata: move ata_altstatus() out to the pio data xfer functions Albert Lee
2007-05-11 7:31 ` [PATCH 4/7] libata: move polling idle irq check to ata_host_intr() Albert Lee
2007-05-11 14:27 ` Tejun Heo
2007-05-11 15:25 ` Albert Lee
2007-05-11 7:35 ` [PATCH 5/7] libata: move and reduce locking to the pio data xfer functions Albert Lee
2007-05-11 14:37 ` Tejun Heo
2007-05-11 14:55 ` Alan Cox
2007-05-11 14:57 ` Tejun Heo
2007-05-11 15:12 ` Alan Cox
2007-05-11 15:14 ` Tejun Heo
2007-05-11 15:24 ` Alan Cox
2007-05-11 15:39 ` Alan Cox
2007-05-11 16:59 ` Tejun Heo
2007-05-11 17:46 ` Alan Cox
2007-05-11 17:53 ` Tejun Heo
2007-05-11 22:00 ` Alan Cox
2007-05-14 8:24 ` Tejun Heo
2007-05-14 11:29 ` Alan Cox
2007-05-11 15:48 ` Albert Lee
2007-05-11 17:06 ` Tejun Heo
2007-05-11 17:38 ` Alan Cox
2007-05-11 17:42 ` Tejun Heo
2007-05-11 17:07 ` Tejun Heo
2007-05-11 7:37 ` [PATCH 6/7] libata: push part of the irq driven pio out to workqueue Albert Lee
2007-05-11 7:41 ` [PATCH 7/7] libata: ack unexpected INTRQ when polling Albert Lee
2007-05-07 14:28 ` [PATCH] libata: disable_irq() during polling IDENTIFY Alan Cox
2007-05-08 13:42 ` Mark Lord
2007-05-08 13:57 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464066A4.1010008@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=albertl@mail.com \
--cc=bzolnier@gmail.com \
--cc=dwm@enoyolf.org \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).