From: Jeff Garzik <jeff@garzik.org>
To: Robert Hancock <hancockr@shaw.ca>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org, Tejun Heo <htejun@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
web01@danzon.com
Subject: Re: [PATCH] sata_nv: fix ADMA freeze/thaw/irq_clear issues
Date: Wed, 09 May 2007 20:17:28 -0400 [thread overview]
Message-ID: <46426498.5050205@garzik.org> (raw)
In-Reply-To: <463CF8E4.6000902@shaw.ca>
Robert Hancock wrote:
> This patch fixes some problems with ADMA-capable controllers with regard
> to freeze,
> thaw and irq_clear libata callbacks. Freeze and thaw didn't switch the
> ADMA-specific
> interrupts on or off, and more critically the irq_clear function didn't
> respect
> the restriction that the notifier clear registers for both ports have to
> be written
> at the same time even when only one port is being cleared. This could
> result in
> timeouts on one port when error handling (i.e. as a result of hotplug)
> occurred on the other port.
>
> As well, this fixes some issues in the interrupt handler: we shouldn't
> check any
> ADMA status if the port has ADMA switched off because of an ATAPI
> device, and
> it also checks to see if any ADMA interrupt has been raised even when we
> are in
> port-register mode.
>
> Signed-off-by: Robert Hancock <hancockr@shaw.ca>
applied
please properly word-wrap your patch descriptions in the future
prev parent reply other threads:[~2007-05-10 0:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-05 21:36 [PATCH] sata_nv: fix ADMA freeze/thaw/irq_clear issues Robert Hancock
2007-05-10 0:17 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46426498.5050205@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=hancockr@shaw.ca \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=web01@danzon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).