linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Paul Mundt <lethal@linux-sh.org>,
	jeff@garzik.org, linux-ide@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: libata reset-seq merge broke sata_sil on sh
Date: Thu, 10 May 2007 13:53:48 +0200	[thread overview]
Message-ID: <464307CC.40701@gmail.com> (raw)
In-Reply-To: <464301D3.5060306@gmail.com>

Some more thoughts.

Tejun Heo wrote:
> Hello,
> 
> Paul Mundt wrote:
> [--snip, thanks a lot for the detailed report--]
>> However, if I go back before any of the reset changes were introduced,
>> things were working fine, and there were no problems with waiting for
>> the reset. Ideas?
> 
> Hmm... It worked so well on all my sil's.  I'm a bit puzzled because we
> also failed the same condition before the change too.  The only change
> is we're less patient with the initial tries but in the end we give more
> than enough time to the device to prepare itself.
> 
> * Does your drive start spun down when it boots?  Can you post dmesg
> with printk timestamp turned on with kernel prior to reset-seq merge?
> 
> * In ata_bus_softreset() and sata_std_hardreset(), there's msleep(150)
> delay before checking the status post-reset.  Does increasing the delay
> make any difference?  Please try to increase it exponentially till it
> reaches 10sec.

* According to the report, things still work till 27c78b37 - commit for
the actual merge and there's no related change till the current master
from there.  So, which commit actually breaks detection?  Or is
detection just flaky after b8cffc6a?

* How does things work on 9b89391c?

Also, please turn on printk timestamp on all reports so that we can now
the timeline of things.

Thanks.

-- 
tejun

  reply	other threads:[~2007-05-10 11:53 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-10  7:20 libata reset-seq merge broke sata_sil on sh Paul Mundt
2007-05-10 11:28 ` Tejun Heo
2007-05-10 11:53   ` Tejun Heo [this message]
2007-05-10 12:46   ` Paul Mundt
2007-05-10 13:08     ` Tejun Heo
2007-05-11  0:52       ` Paul Mundt
2007-05-11  9:39         ` Tejun Heo
2007-05-12  3:49           ` Paul Mundt
2007-05-16  0:30             ` Paul Mundt
2007-05-16 16:44               ` [PATCH] libata: implement ata_wait_after_reset() Tejun Heo
2007-05-17  0:50                 ` Paul Mundt
2007-05-17  0:59                 ` Paul Mundt
2007-05-19 15:54                 ` Indan Zupancic
2007-05-19 18:23                   ` Tejun Heo
2007-05-19 22:54                     ` Indan Zupancic
2007-05-20  9:50                       ` Tejun Heo
2007-05-20 13:26                         ` Indan Zupancic
2007-05-20 17:09                           ` Tejun Heo
2007-05-20 19:35                             ` Indan Zupancic
2007-05-19 16:39                 ` Indan Zupancic
2007-05-19 18:43                   ` Tejun Heo
2007-05-19 19:04                     ` Tejun Heo
2007-05-19 22:33                       ` sd_resume redundant? [was: [PATCH] libata: implement ata_wait_after_reset()] Indan Zupancic
2007-05-20  9:54                         ` Tejun Heo
2007-05-20 14:27                           ` Indan Zupancic
2007-05-20 17:17                             ` Tejun Heo
2007-05-20 19:47                               ` Indan Zupancic
2007-05-21  6:02                       ` [PATCH] libata: implement ata_wait_after_reset() Paul Mundt
2007-05-29  1:31                 ` Jeff Garzik
2007-05-29  7:33                   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=464307CC.40701@gmail.com \
    --to=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=lethal@linux-sh.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).