From: Mark Lord <lkml@rtr.ca>
To: Tejun Heo <htejun@gmail.com>
Cc: Robert Hancock <hancockr@shaw.ca>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH] libata: add human-readable error value decoding
Date: Thu, 10 May 2007 09:24:41 -0400 [thread overview]
Message-ID: <46431D19.1070308@rtr.ca> (raw)
In-Reply-To: <4642E92D.5010509@gmail.com>
Tejun Heo wrote:
> Robert Hancock wrote:
>> This adds human-readable decoding of the ATA status and error registers
>> (similar
>> to what drivers/ide does) as well as the SATA Serror register to libata
...
> I'm not really convinced whether this is necessary. The human readable
> form is also a bit cryptic and can get quite long. So, mild NACK from me.
Same here, but I would like to see it in there under a CONFIG_DEBUG_LIBATA
kernel build option or something. Kind of like the "FANCY_STATUS_DUMPS" flag
that drivers/ide used to have for this kind of stuff.
Cheers
next prev parent reply other threads:[~2007-05-10 13:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 2:18 [PATCH] libata: add human-readable error value decoding Robert Hancock
2007-05-10 9:43 ` Tejun Heo
2007-05-10 13:24 ` Mark Lord [this message]
2007-05-10 16:40 ` Jeff Garzik
2007-05-10 21:33 ` Mark Lord
2007-05-10 21:42 ` Jeff Garzik
2007-05-10 23:32 ` Robert Hancock
2007-05-10 23:47 ` Jeff Garzik
2007-05-11 0:55 ` Alan Cox
2007-05-10 23:29 ` Robert Hancock
2007-05-11 16:48 ` Chuck Ebbert
2007-05-11 17:11 ` Tejun Heo
2007-05-11 23:10 ` Robert Hancock
2007-05-11 23:22 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46431D19.1070308@rtr.ca \
--to=lkml@rtr.ca \
--cc=akpm@linux-foundation.org \
--cc=hancockr@shaw.ca \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).