From: Mark Lord <liml@rtr.ca>
To: Jeff Garzik <jeff@garzik.org>
Cc: Tejun Heo <htejun@gmail.com>, Robert Hancock <hancockr@shaw.ca>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] libata: add human-readable error value decoding
Date: Thu, 10 May 2007 17:33:32 -0400 [thread overview]
Message-ID: <46438FAC.1030702@rtr.ca> (raw)
In-Reply-To: <46434AE5.8060605@garzik.org>
Jeff Garzik wrote:
> Mark Lord wrote:
>> Same here, but I would like to see it in there under a
>> CONFIG_DEBUG_LIBATA
>> kernel build option or something. Kind of like the
>> "FANCY_STATUS_DUMPS" flag
>> that drivers/ide used to have for this kind of stuff.
>
>
> The long term goal is to enable verbose output with a module option
> and/or sysfs knob, rather than a compile-time switch.
If we're compiling the messages into the kernel regardless,
then it doesn't really make much sense to NOT show all of them
on the error paths.
This stuff (fancy status dumps) is mostly just for the error paths,
where more information is always a good thing.
Controlling the rest of the ata_msg_xxx stuff from sysctl is fine
for non-error paths.
Cheers
next prev parent reply other threads:[~2007-05-10 21:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 2:18 [PATCH] libata: add human-readable error value decoding Robert Hancock
2007-05-10 9:43 ` Tejun Heo
2007-05-10 13:24 ` Mark Lord
2007-05-10 16:40 ` Jeff Garzik
2007-05-10 21:33 ` Mark Lord [this message]
2007-05-10 21:42 ` Jeff Garzik
2007-05-10 23:32 ` Robert Hancock
2007-05-10 23:47 ` Jeff Garzik
2007-05-11 0:55 ` Alan Cox
2007-05-10 23:29 ` Robert Hancock
2007-05-11 16:48 ` Chuck Ebbert
2007-05-11 17:11 ` Tejun Heo
2007-05-11 23:10 ` Robert Hancock
2007-05-11 23:22 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46438FAC.1030702@rtr.ca \
--to=liml@rtr.ca \
--cc=akpm@linux-foundation.org \
--cc=hancockr@shaw.ca \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).