linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Albert Lee <albertcc@tw.ibm.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Tejun Heo <htejun@gmail.com>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Linux IDE <linux-ide@vger.kernel.org>,
	Doug Maxey <dwm@enoyolf.org>,
	bzolnier@gmail.com, Mark Lord <liml@rtr.ca>
Subject: [PATCH 1/7] libata: set the state after "PIO data-in" to HSM_ST_IDLE instead of HSM_ST_LAST
Date: Fri, 11 May 2007 15:24:48 +0800	[thread overview]
Message-ID: <46441A40.4020403@tw.ibm.com> (raw)
In-Reply-To: <4644192A.8090809@tw.ibm.com>

patch 1/7:
  Set the state after "PIO data-in" to HSM_ST_IDLE instead of HSM_ST_LAST.
To prevent the irq handler from thinking "HSM is waiting for the last irq".
Needed later when part of the irq driven pio pushed out to workqueue.

---

diff -Nrup 00_linux-2.6.21.1/drivers/ata/libata-core.c 01_last_idle/drivers/ata/libata-core.c
--- 00_linux-2.6.21.1/drivers/ata/libata-core.c	2007-05-04 11:22:23.000000000 +0800
+++ 01_last_idle/drivers/ata/libata-core.c	2007-05-11 10:24:16.000000000 +0800
@@ -4041,7 +4041,7 @@ static void ata_pio_sector(struct ata_qu
 	unsigned char *buf;
 
 	if (qc->curbytes == qc->nbytes - ATA_SECT_SIZE)
-		ap->hsm_task_state = HSM_ST_LAST;
+		ap->hsm_task_state = do_write ? HSM_ST_LAST : HSM_ST_IDLE;
 
 	page = sg[qc->cursg].page;
 	offset = sg[qc->cursg].offset + qc->cursg_ofs;
@@ -4389,6 +4389,8 @@ int ata_hsm_move(struct ata_port *ap, st
 	 */
 	WARN_ON(in_wq != ata_hsm_ok_in_wq(ap, qc));
 
+	WARN_ON(ap->hsm_task_state == HSM_ST_IDLE);
+
 fsm_start:
 	DPRINTK("ata%u: protocol %d task_state %d (dev_stat 0x%X)\n",
 		ap->print_id, qc->tf.protocol, ap->hsm_task_state, status);
@@ -4548,8 +4550,7 @@ fsm_start:
 
 			ata_pio_sectors(qc);
 
-			if (ap->hsm_task_state == HSM_ST_LAST &&
-			    (!(qc->tf.flags & ATA_TFLAG_WRITE))) {
+			if (ap->hsm_task_state == HSM_ST_IDLE) {
 				/* all data read */
 				ata_altstatus(ap);
 				status = ata_wait_idle(ap);
@@ -4562,6 +4563,7 @@ fsm_start:
 		break;
 
 	case HSM_ST_LAST:
+	case HSM_ST_IDLE:
 		if (unlikely(!ata_ok(status))) {
 			qc->err_mask |= __ac_err_mask(status);
 			ap->hsm_task_state = HSM_ST_ERR;



  reply	other threads:[~2007-05-11  7:24 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-07  4:30 [PATCH] libata: disable_irq() during polling IDENTIFY Albert Lee
2007-05-07  7:43 ` Tejun Heo
2007-05-07 11:18   ` Alan Cox
2007-05-07 11:32     ` Tejun Heo
2007-05-08 13:36       ` Mark Lord
2007-05-07 11:19   ` Albert Lee
2007-05-07 11:29     ` Tejun Heo
2007-05-07 11:54       ` Albert Lee
2007-05-07 12:01         ` Tejun Heo
2007-05-08 11:30           ` [PATCH] libata: disable_irq() during polling IDENTIFY (take 2) Albert Lee
2007-05-08 11:41             ` Tejun Heo
2007-05-08 12:00             ` Alan Cox
2007-05-08 12:01               ` Tejun Heo
2007-05-08 12:20                 ` Alan Cox
2007-05-08 12:27                   ` Tejun Heo
2007-05-08 12:43                     ` Alan Cox
2007-05-08 12:45                       ` Tejun Heo
2007-05-08 12:45                     ` Alan Cox
2007-05-08 12:57                       ` Tejun Heo
2007-05-08 14:59                         ` Albert Lee
2007-05-08 15:16                         ` Jeff Garzik
2007-05-11  7:20                         ` [PATCH/RFC 0/7] libata: push part of irq driven pio to workqueue Albert Lee
2007-05-11  7:24                           ` Albert Lee [this message]
2007-05-11  7:28                           ` [PATCH 2/7] libata: move the ata_altstatus() in ata_hsm_qc_complete() Albert Lee
2007-05-11  7:30                           ` [PATCH 3/7] libata: move ata_altstatus() out to the pio data xfer functions Albert Lee
2007-05-11  7:31                           ` [PATCH 4/7] libata: move polling idle irq check to ata_host_intr() Albert Lee
2007-05-11 14:27                             ` Tejun Heo
2007-05-11 15:25                               ` Albert Lee
2007-05-11  7:35                           ` [PATCH 5/7] libata: move and reduce locking to the pio data xfer functions Albert Lee
2007-05-11 14:37                             ` Tejun Heo
2007-05-11 14:55                               ` Alan Cox
2007-05-11 14:57                                 ` Tejun Heo
2007-05-11 15:12                                   ` Alan Cox
2007-05-11 15:14                                     ` Tejun Heo
2007-05-11 15:24                                       ` Alan Cox
2007-05-11 15:39                                       ` Alan Cox
2007-05-11 16:59                                         ` Tejun Heo
2007-05-11 17:46                                           ` Alan Cox
2007-05-11 17:53                                             ` Tejun Heo
2007-05-11 22:00                                               ` Alan Cox
2007-05-14  8:24                                                 ` Tejun Heo
2007-05-14 11:29                                                   ` Alan Cox
2007-05-11 15:48                               ` Albert Lee
2007-05-11 17:06                                 ` Tejun Heo
2007-05-11 17:38                                   ` Alan Cox
2007-05-11 17:42                                     ` Tejun Heo
2007-05-11 17:07                                 ` Tejun Heo
2007-05-11  7:37                           ` [PATCH 6/7] libata: push part of the irq driven pio out to workqueue Albert Lee
2007-05-11  7:41                           ` [PATCH 7/7] libata: ack unexpected INTRQ when polling Albert Lee
2007-05-07 14:28         ` [PATCH] libata: disable_irq() during polling IDENTIFY Alan Cox
2007-05-08 13:42           ` Mark Lord
2007-05-08 13:57             ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46441A40.4020403@tw.ibm.com \
    --to=albertcc@tw.ibm.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=albertl@mail.com \
    --cc=bzolnier@gmail.com \
    --cc=dwm@enoyolf.org \
    --cc=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).