From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH/RFC] Fix build failure for drivers/ata/pata_scc.c Date: Fri, 11 May 2007 13:56:08 +0200 Message-ID: <464459D8.1030305@gmail.com> References: <20070511064954.GE15955@bakeyournoodle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from py-out-1112.google.com ([64.233.166.181]:58242 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756803AbXEKL4V (ORCPT ); Fri, 11 May 2007 07:56:21 -0400 Received: by py-out-1112.google.com with SMTP id a29so763704pyi for ; Fri, 11 May 2007 04:56:20 -0700 (PDT) In-Reply-To: <20070511064954.GE15955@bakeyournoodle.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tony Breeds Cc: Linux Kernel ML , Akira Iguchi , Jeff Garzik , linux-ide@vger.kernel.org, cbe-oss-dev@ozlabs.org Tony Breeds wrote: > The commit d4b2bab4f26345ea1803feb23ea92fbe3f6b77bc added deadline support to > prereset and reset methods to libbata the pata_scc driver wasn't converted. > This patch is a naive attempt to bring this driver up to scratch. > > Build failures are: > drivers/ata/pata_scc.c: In function 'scc_pata_prereset': > drivers/ata/pata_scc.c:870: error: too few arguments to function 'ata_std_prereset' > drivers/ata/pata_scc.c: In function 'scc_error_handler': > drivers/ata/pata_scc.c:916: warning: passing argument 2 of 'ata_bmdma_drive_eh' from incompatible pointer type > drivers/ata/pata_scc.c:916: warning: passing argument 3 of 'ata_bmdma_drive_eh' from incompatible pointer type > drivers/ata/pata_scc.c: In function 'scc_pata_prereset': > drivers/ata/pata_scc.c:871: warning: control reaches end of non-void function > > On a releated note scc_bus_post_reset() is (AFACT) identical to > ata_bus_post_reset(), would a patch to make ata_bus_post_reset() assesable to > drivers be accepted? > > > Signed-off-by: Tony Breeds > CC: Tejun Heo > CC: Akira Iguchi > CC: Jeff Garzik > CC: linux-ide@vger.kernel.org Acked-by: Tejun Heo -- tejun