From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert Lee Subject: Re: [PATCH 4/7] libata: move polling idle irq check to ata_host_intr() Date: Fri, 11 May 2007 23:25:35 +0800 Message-ID: <46448AEF.2010902@tw.ibm.com> References: <463EAB4D.3000309@tw.ibm.com> <463ED8B9.4060501@gmail.com> <463F0B25.40103@tw.ibm.com> <463F0DAD.5060307@gmail.com> <463F1374.1010100@tw.ibm.com> <463F1509.30100@gmail.com> <46405F50.5090901@tw.ibm.com> <20070508130025.7693980c@the-village.bc.nu> <464066A4.1010008@gmail.com> <20070508132046.70a4d9ed@the-village.bc.nu> <46406C9A.4000802@gmail.com> <20070508134540.509f4704@the-village.bc.nu> <464073B1.80303@gmail.com> <4644192A.8090809@tw.ibm.com> <46441BED.9040108@tw.ibm.com> <46447D57.7040603@gmail.com> Reply-To: albertl@mail.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from e32.co.us.ibm.com ([32.97.110.150]:54588 "EHLO e32.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755414AbXEKPZy (ORCPT ); Fri, 11 May 2007 11:25:54 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e32.co.us.ibm.com (8.12.11.20060308/8.13.8) with ESMTP id l4BFMN5x019000 for ; Fri, 11 May 2007 11:22:23 -0400 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l4BFPoSn199732 for ; Fri, 11 May 2007 09:25:50 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l4BFPn3f016513 for ; Fri, 11 May 2007 09:25:50 -0600 In-Reply-To: <46447D57.7040603@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Jeff Garzik , Alan Cox , Linux IDE , Doug Maxey , bzolnier@gmail.com, Mark Lord Tejun Heo wrote: >> >>diff -Nrup 03_smart_flush/drivers/ata/libata-core.c 04_polling_check/drivers/ata/libata-core.c >>--- 03_smart_flush/drivers/ata/libata-core.c 2007-05-11 10:24:19.000000000 +0800 >>+++ 04_polling_check/drivers/ata/libata-core.c 2007-05-11 10:25:09.000000000 +0800 >>@@ -5119,6 +5119,10 @@ inline unsigned int ata_host_intr (struc >> VPRINTK("ata%u: protocol %d task_state %d\n", >> ap->print_id, qc->tf.protocol, ap->hsm_task_state); >> >>+ /* polling */ >>+ if (qc->tf.flags & ATA_TFLAG_POLLING) >>+ goto idle_irq; >>+ >> /* Check whether we are expecting interrupt in this state */ >> switch (ap->hsm_task_state) { >> case HSM_ST_FIRST: >>@@ -5229,8 +5233,7 @@ irqreturn_t ata_interrupt (int irq, void >> struct ata_queued_cmd *qc; >> >> qc = ata_qc_from_tag(ap, ap->active_tag); >>- if (qc && (!(qc->tf.flags & ATA_TFLAG_POLLING)) && >>- (qc->flags & ATA_QCFLAG_ACTIVE)) >>+ if (qc && (qc->flags & ATA_QCFLAG_ACTIVE)) > > > There are several LLD specific IRQ handlers which have similar part. > Care to update them together? > Sure, will do. -- albert