From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chuck Ebbert Subject: Re: [PATCH] libata: add human-readable error value decoding Date: Fri, 11 May 2007 12:48:25 -0400 Message-ID: <46449E59.90608@redhat.com> References: <46428103.3040003@shaw.ca> <4642E92D.5010509@gmail.com> <4643AAF6.7080204@shaw.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([66.187.233.31]:34956 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757929AbXEKQse (ORCPT ); Fri, 11 May 2007 12:48:34 -0400 In-Reply-To: <4643AAF6.7080204@shaw.ca> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Robert Hancock Cc: Tejun Heo , linux-kernel , linux-ide@vger.kernel.org, Andrew Morton , Jeff Garzik Robert Hancock wrote: >>> + ehc->i.serror & SERR_TRANS_ST_ERROR ? "TransStatTransErr " >>> : "", >>> + ehc->i.serror & SERR_UNRECOG_FIS ? "UnrecogFIS " : "", >>> + ehc->i.serror & SERR_DEV_XCHG ? "DevExchanged " : "" ); >> >> I'm not really convinced whether this is necessary. The human readable >> form is also a bit cryptic and can get quite long. So, mild NACK from >> me. >> > > It certainly seems useful when debugging hotplug issues or random SATA > problems which end up being caused by communication problems. Without > this output, Joe User stands no chance of figuring out what's going on, > and neither does Joe libata Developer unless they really care to dig > through the spec and count bits to figure out what they mean. At least > with this you can see that there was a CRC error, etc. and go from that.. > Why not just document the error messages? And the scsi ones too, I can't seem to find what the sense codes mean.