From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mark Lord <lkml@rtr.ca>,
hancockr@shaw.ca, cebbert@redhat.com,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
emisca.ml@gmail.com,
IDE/ATA development list <linux-ide@vger.kernel.org>,
Stephen.Clark@seclark.us, fabio.comolli@gmail.com,
a.p.zijlstra@chello.nl
Subject: Re: [PATCH 1/2] libata: reimplement suspend/resume support using sdev->manage_start_stop
Date: Fri, 11 May 2007 16:39:38 -0400 [thread overview]
Message-ID: <4644D48A.4090301@garzik.org> (raw)
In-Reply-To: <46445CFF.5060709@gmail.com>
Tejun Heo wrote:
> Jeff Garzik wrote:
>> Tejun Heo wrote:
>>> Reimplement suspend/resume support using sdev->manage_start_stop.
>>>
>>> * Device suspend/resume is now SCSI layer's responsibility and the
>>> code is simplified a lot.
>>>
>>> * DPM is dropped. This also simplifies code a lot. Suspend/resume
>>> status is port-wide now.
>>>
>>> * ata_scsi_device_suspend/resume() and ata_dev_ready() removed.
>>>
>>> * Resume now has to wait for disk to spin up before proceeding. I
>>> couldn't find easy way out as libata is in EH waiting for the
>>> disk to be ready and sd is waiting for EH to complete to issue
>>> START_STOP.
>>>
>>> * sdev->manage_start_stop is set to 1 in ata_scsi_slave_config().
>>> This fixes spindown on shutdown and suspend-to-disk.
>>>
>>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>> applied patches 1-2, but explicitly did not send them upstream today.
>>
>> I'm hoping we can get this into 2.6.22 -- but also expose it in -mm for
>> a few days as well.
>
> Okay, will prepare the scary webpage then.
huh?
Jeff
next prev parent reply other threads:[~2007-05-11 20:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-04 19:26 [PATCHSET] libata: reimplement suspend/resume support and fix spindown on poweroff Tejun Heo
2007-05-04 19:27 ` [PATCH 1/2] libata: reimplement suspend/resume support using sdev->manage_start_stop Tejun Heo
2007-05-10 1:42 ` Jeff Garzik
2007-05-11 12:09 ` Tejun Heo
2007-05-11 20:39 ` Jeff Garzik [this message]
2007-05-04 19:28 ` [PATCH 2/2] libata: implement libata.spindown_compat Tejun Heo
2007-05-06 20:11 ` [PATCHSET] libata: reimplement suspend/resume support and fix spindown on poweroff Fabio Comolli
2007-05-06 20:24 ` Tejun Heo
2007-05-06 21:29 ` Fabio Comolli
-- strict thread matches above, loose matches on Subject: below --
2007-04-23 19:12 [PATCH 1/2] libata: reimplement suspend/resume support using sdev->manage_start_stop Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4644D48A.4090301@garzik.org \
--to=jeff@garzik.org \
--cc=Stephen.Clark@seclark.us \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=cebbert@redhat.com \
--cc=emisca.ml@gmail.com \
--cc=fabio.comolli@gmail.com \
--cc=hancockr@shaw.ca \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=lkml@rtr.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).