From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] libata: give devices one last chance even if recovery failed with -EINVAL Date: Fri, 11 May 2007 18:10:58 -0400 Message-ID: <4644E9F2.3000706@garzik.org> References: <464465BB.5070203@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:43614 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933947AbXEKWLA (ORCPT ); Fri, 11 May 2007 18:11:00 -0400 In-Reply-To: <464465BB.5070203@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: IDE/ATA development list Tejun Heo wrote: > After certain errors, some devices report complete garbage on > IDENTIFY. This can cause ata_dev_read_id() to fail with -EINVAL > resulting in immediate disabling of the device. Give the device one > last chance after -EINVAL to allow recovery from such situations. As > -EINVAL is triggered very rarely, this shouldn't cause any noticeable > affect on more common error paths. > > Signed-off-by: Tejun Heo > Cc: Harald Dunkel applied