From: Jeff Garzik <jeff@garzik.org>
To: akpm@linux-foundation.org
Cc: linux-ide@vger.kernel.org, oleg@tv-sign.ru
Subject: Re: [patch 12/20] libata-core: convert to use cancel_rearming_delayed_work()
Date: Fri, 11 May 2007 18:15:44 -0400 [thread overview]
Message-ID: <4644EB10.5010307@garzik.org> (raw)
In-Reply-To: <200705110548.l4B5mr2h007648@shell0.pdx.osdl.net>
akpm@linux-foundation.org wrote:
> From: Oleg Nesterov <oleg@tv-sign.ru>
>
> We should not use cancel_work_sync(delayed_work->work). This works, but not
> good. We can use cancel_rearming_delayed_work(), this also simplifies the
> code.
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/ata/libata-core.c | 44 +++---------------------------------
> include/linux/libata.h | 1
> 2 files changed, 4 insertions(+), 41 deletions(-)
Agreed with Tejun, this can be cleaned up further. OK with general approach
prev parent reply other threads:[~2007-05-11 22:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 5:48 [patch 12/20] libata-core: convert to use cancel_rearming_delayed_work() akpm
2007-05-11 22:15 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4644EB10.5010307@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=linux-ide@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).