From: Jeff Garzik <jeff@garzik.org>
To: Robert Hancock <hancockr@shaw.ca>
Cc: Tejun Heo <htejun@gmail.com>, Chuck Ebbert <cebbert@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] libata: add human-readable error value decoding
Date: Fri, 11 May 2007 19:22:44 -0400 [thread overview]
Message-ID: <4644FAC4.4010809@garzik.org> (raw)
In-Reply-To: <4644F7EC.3080607@shaw.ca>
Robert Hancock wrote:
> The ATA ones are more of a pain in that regard than SCSI though - SCSI
> has all distinct error codes for different errors, whereas ATA has
> bitmasks for everything..
That should not affect implementation. Either way, a table-driven
approach can easily work.
I favor decoding the SError status bits, but your names were far too
long. "ProtocolErr" should be "Proto". "10B8BErr" should be "10b8b".
HostInternalErr to HostInt. PHYInternalErr to PHYInt. etc.
Jeff
prev parent reply other threads:[~2007-05-11 23:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 2:18 [PATCH] libata: add human-readable error value decoding Robert Hancock
2007-05-10 9:43 ` Tejun Heo
2007-05-10 13:24 ` Mark Lord
2007-05-10 16:40 ` Jeff Garzik
2007-05-10 21:33 ` Mark Lord
2007-05-10 21:42 ` Jeff Garzik
2007-05-10 23:32 ` Robert Hancock
2007-05-10 23:47 ` Jeff Garzik
2007-05-11 0:55 ` Alan Cox
2007-05-10 23:29 ` Robert Hancock
2007-05-11 16:48 ` Chuck Ebbert
2007-05-11 17:11 ` Tejun Heo
2007-05-11 23:10 ` Robert Hancock
2007-05-11 23:22 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4644FAC4.4010809@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=cebbert@redhat.com \
--cc=hancockr@shaw.ca \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).