[patch 08/20] drivers/ata: remove the wildcard from sata_nv driver

[patch 08/20] drivers/ata: remove the wildcard from sata_nv driver

[akpm]

From: "Peer Chen" <pchen@nvidia.com>

Because nvidia SATA controllers onward base on AHCI, so wildcard in sata_nv
driver is unnecessary.  Also the wildcard sometimes cause sata_nv driver to
be loaded for AHCI controllers,which is not as expected.

Signed-off-by: Peer Chen <pchen@nvidia.com>
Cc: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/ata/sata_nv.c |    6 ------
 1 file changed, 6 deletions(-)

diff -puN drivers/ata/sata_nv.c~drivers-ata-remove-the-wildcard-from-sata_nv-driver drivers/ata/sata_nv.c
--- a/drivers/ata/sata_nv.c~drivers-ata-remove-the-wildcard-from-sata_nv-driver
+++ a/drivers/ata/sata_nv.c
@@ -288,12 +288,6 @@ static const struct pci_device_id nv_pci
 	{ PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA), GENERIC },
 	{ PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA2), GENERIC },
 	{ PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA3), GENERIC },
-	{ PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID,
-		PCI_ANY_ID, PCI_ANY_ID,
-		PCI_CLASS_STORAGE_IDE<<8, 0xffff00, GENERIC },
-	{ PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID,
-		PCI_ANY_ID, PCI_ANY_ID,
-		PCI_CLASS_STORAGE_RAID<<8, 0xffff00, GENERIC },
 
 	{ } /* terminate list */
 };
_

Re: [patch 08/20] drivers/ata: remove the wildcard from sata_nv driver

[Tejun Heo]

akpm@linux-foundation.org wrote:
> From: "Peer Chen" <pchen@nvidia.com>
> 
> Because nvidia SATA controllers onward base on AHCI, so wildcard in sata_nv
> driver is unnecessary.  Also the wildcard sometimes cause sata_nv driver to
> be loaded for AHCI controllers,which is not as expected.
> 
> Signed-off-by: Peer Chen <pchen@nvidia.com>
> Cc: Tejun Heo <htejun@gmail.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Peer Chen, are you sure we don't miss any existing devices by doing
this?  Also, what would future nvidia chips look like?  AHCI only or
dual mode similar ICHs?  If compatible mode is going to be supported &&
there is no switch we can mangle from PCI quirks to put it into AHCI
mode, we might wanna keep PCI_CLASS_STORAGE_IDE assuming compatible mode
interface remains similar.

Thanks.

-- 
tejun

RE: [patch 08/20] drivers/ata: remove the wildcard from sata_nv driver

[Peer Chen]

Tejun,
The future nvidia chips are all base on AHCI and also they can support
compatible mode,but current sata_nv have the bug with compatible mode
for AHCI controller,we need to modify the sata_nv driver then submit the
patch. Before that,if users load the sata_nv driver for our AHCI
controllers,they will encounter that bug.


BRs
Peer Chen

-----Original Message-----
From: Tejun Heo [mailto:htejun@gmail.com] 
Sent: Friday, May 11, 2007 7:49 PM
To: akpm@linux-foundation.org; Peer Chen
Cc: jeff@garzik.org; linux-ide@vger.kernel.org
Subject: Re: [patch 08/20] drivers/ata: remove the wildcard from sata_nv
driver

akpm@linux-foundation.org wrote:
> From: "Peer Chen" <pchen@nvidia.com>
> 
> Because nvidia SATA controllers onward base on AHCI, so wildcard in
sata_nv
> driver is unnecessary.  Also the wildcard sometimes cause sata_nv
driver to
> be loaded for AHCI controllers,which is not as expected.
> 
> Signed-off-by: Peer Chen <pchen@nvidia.com>
> Cc: Tejun Heo <htejun@gmail.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Peer Chen, are you sure we don't miss any existing devices by doing
this?  Also, what would future nvidia chips look like?  AHCI only or
dual mode similar ICHs?  If compatible mode is going to be supported &&
there is no switch we can mangle from PCI quirks to put it into AHCI
mode, we might wanna keep PCI_CLASS_STORAGE_IDE assuming compatible mode
interface remains similar.

Thanks.

-- 
tejun
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

Re: [patch 08/20] drivers/ata: remove the wildcard from sata_nv driver

[Tejun Heo]

Hello,

Peer Chen wrote:
> Tejun,
> The future nvidia chips are all base on AHCI and also they can support
> compatible mode,but current sata_nv have the bug with compatible mode
> for AHCI controller,we need to modify the sata_nv driver then submit the
> patch.

Yes, please do that.

> Before that,if users load the sata_nv driver for our AHCI
> controllers,they will encounter that bug.

What kind of bug are we talking about?

Thanks.

-- 
tejun

RE: [patch 08/20] drivers/ata: remove the wildcard from sata_nv driver

[Peer Chen]

As following, the scr registers' offset in sata_nv driver is 0x0 & 0x40,
but offset 0x0 in BAR5 memory map of AHCI controller is 'HBA
Capabilities register', the value of this register make the driver
believe there is always a HD drive being connected to port0,so error
happen.
==============================================
	NV_PORT0_SCR_REG_OFFSET		= 0x00,
	NV_PORT1_SCR_REG_OFFSET		= 0x40, 


BRs
Peer Chen

-----Original Message-----
From: Tejun Heo [mailto:htejun@gmail.com] 
Sent: Monday, May 14, 2007 5:29 PM
To: Peer Chen
Cc: akpm@linux-foundation.org; jeff@garzik.org;
linux-ide@vger.kernel.org
Subject: Re: [patch 08/20] drivers/ata: remove the wildcard from sata_nv
driver

Hello,

Peer Chen wrote:
> Tejun,
> The future nvidia chips are all base on AHCI and also they can support
> compatible mode,but current sata_nv have the bug with compatible mode
> for AHCI controller,we need to modify the sata_nv driver then submit
the
> patch.

Yes, please do that.

> Before that,if users load the sata_nv driver for our AHCI
> controllers,they will encounter that bug.

What kind of bug are we talking about?

Thanks.

-- 
tejun
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

Re: [patch 08/20] drivers/ata: remove the wildcard from sata_nv driver

[Tejun Heo]

Peer Chen wrote:
> As following, the scr registers' offset in sata_nv driver is 0x0 & 0x40,
> but offset 0x0 in BAR5 memory map of AHCI controller is 'HBA
> Capabilities register', the value of this register make the driver
> believe there is always a HD drive being connected to port0,so error
> happen.
> ==============================================
> 	NV_PORT0_SCR_REG_OFFSET		= 0x00,
> 	NV_PORT1_SCR_REG_OFFSET		= 0x40, 

OIC, no objection to the original patch and please fix this one.

Thanks.

-- 
tejun

Re: [patch 08/20] drivers/ata: remove the wildcard from sata_nv driver

[Jeff Garzik]

akpm@linux-foundation.org wrote:
> From: "Peer Chen" <pchen@nvidia.com>
> 
> Because nvidia SATA controllers onward base on AHCI, so wildcard in sata_nv
> driver is unnecessary.  Also the wildcard sometimes cause sata_nv driver to
> be loaded for AHCI controllers,which is not as expected.
> 
> Signed-off-by: Peer Chen <pchen@nvidia.com>
> Cc: Tejun Heo <htejun@gmail.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/ata/sata_nv.c |    6 ------
>  1 file changed, 6 deletions(-)

applied