From: Tejun Heo <htejun@gmail.com>
To: Peer Chen <pchen@nvidia.com>
Cc: akpm@linux-foundation.org, jeff@garzik.org, linux-ide@vger.kernel.org
Subject: Re: [patch 08/20] drivers/ata: remove the wildcard from sata_nv driver
Date: Mon, 14 May 2007 12:10:17 +0200 [thread overview]
Message-ID: <46483589.3060105@gmail.com> (raw)
In-Reply-To: <15F501D1A78BD343BE8F4D8DB854566B13CD865E@hkemmail01.nvidia.com>
Peer Chen wrote:
> As following, the scr registers' offset in sata_nv driver is 0x0 & 0x40,
> but offset 0x0 in BAR5 memory map of AHCI controller is 'HBA
> Capabilities register', the value of this register make the driver
> believe there is always a HD drive being connected to port0,so error
> happen.
> ==============================================
> NV_PORT0_SCR_REG_OFFSET = 0x00,
> NV_PORT1_SCR_REG_OFFSET = 0x40,
OIC, no objection to the original patch and please fix this one.
Thanks.
--
tejun
next prev parent reply other threads:[~2007-05-14 10:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 5:48 [patch 08/20] drivers/ata: remove the wildcard from sata_nv driver akpm
2007-05-11 11:49 ` Tejun Heo
2007-05-14 8:14 ` Peer Chen
2007-05-14 9:29 ` Tejun Heo
2007-05-14 10:06 ` Peer Chen
2007-05-14 10:10 ` Tejun Heo [this message]
2007-05-18 0:57 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46483589.3060105@gmail.com \
--to=htejun@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=pchen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).