Re: [PATCH] libata: track spindown status and skip spindown_compat if possible

[Stephen Clark <Stephen.Clark@seclark.us>]

Tejun Heo wrote:

>Francesco Pretto wrote:
>  
>
>>Tejun Heo <htejun <at> gmail.com> writes:
>>    
>>
>>>Our assumption that most distros issue STANDBYNOW seems wrong.  The
>>>upstream sysvinit and thus many distros including gentoo and opensuse
>>>don't take any action for libata disks on spindown.  We can skip
>>>compat handling for these distros so that they don't need to update
>>>anything to take advantage of kernel-side shutdown.
>>>
>>>      
>>>
>>Working around the workaround won't make confusion? Won't this break again
>>implementations that was actually issuing STANDBYNOW, assuming that they
>>actually exist? Only wondering, can't say for any init implementation in
>>particular.
>>    
>>
>
>Yeah, it's a big mess.  With this patch applied, what happens is...
>
>* If your shutdown(8) does issue STANDBYNOW : you get the big fat
>warning and kernel won't issue STANDBYNOW.
>
>* If your shutdown(8) doesn't issue STANDBYNOW : kernel issues FLUSH
>CACHE followed by STANDBYNOW and all is well and dandy without any
>userland modification.
>
>I think it isn't too bad.  Any better ideas?
>
>  
>
Ok, I am running fc6 with kernel.org 2.6.21 what do I need to do to keep 
my laptop from
popping, and having my retract_count increment, every time I shutdown?

Thanks,
Steve

-- 

"They that give up essential liberty to obtain temporary safety, 
deserve neither liberty nor safety."  (Ben Franklin)

"The course of history shows that as a government grows, liberty 
decreases."  (Thomas Jefferson)