From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] sata_nv: fix fallout of devres conversion Date: Thu, 17 May 2007 20:58:10 -0400 Message-ID: <464CFA22.1090600@garzik.org> References: <15F501D1A78BD343BE8F4D8DB854566B13CD8F45@hkemmail01.nvidia.com> <464A94D7.30300@garzik.org> <15F501D1A78BD343BE8F4D8DB854566B13DEF520@hkemmail01.nvidia.com> <464C38F5.3060802@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:43705 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756579AbXERA6N (ORCPT ); Thu, 17 May 2007 20:58:13 -0400 In-Reply-To: <464C38F5.3060802@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Peer Chen , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, IDE/ATA development list Tejun Heo wrote: > As with all other drivers, sata_nv's hpriv is allocated with > devm_kzalloc() and there's no need to free it explicitly. Kill > nv_remove_one() which incorrectly used kfree() instead of devm_kfree() > and use ata_pci_remove_one() directly. > > Original fix is from Peer Chen. > > Signed-off-by: Tejun Heo > Cc: Peer Chen > --- > > I think it's prettier this way. :-) applied you forgot diffstat :)