linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Add Seagate STT20000A to DMA blacklist.
@ 2007-05-21 14:50 Dave Jones
  2007-05-21 16:15 ` Alan Cox
  2007-05-24  0:33 ` Bartlomiej Zolnierkiewicz
  0 siblings, 2 replies; 7+ messages in thread
From: Dave Jones @ 2007-05-21 14:50 UTC (permalink / raw)
  To: Linux Kernel; +Cc: bzolnier, linux-ide

http://bugzilla.kernel.org/show_bug.cgi?id=1044
has been open for _four_ years with a patch available.
Here's a rediffed version of the same.

Signed-off-by: Dave Jones <davej@redhat.com>

--- linux-2.6/drivers/ide/ide-dma.c~	2007-05-21 10:48:11.000000000 -0400
+++ linux-2.6/drivers/ide/ide-dma.c	2007-05-21 10:48:21.000000000 -0400
@@ -127,7 +127,8 @@ static const struct drive_list_entry dri
 	{ "SAMSUNG CD-ROM SC",	"ALL"		},
 	{ "SanDisk SDP3B-64"	,	"ALL"		},
 	{ "ATAPI CD-ROM DRIVE 40X MAXIMUM",	"ALL"		},
-	{ "_NEC DV5800A",               "ALL"           },  
+	{ "_NEC DV5800A",               "ALL"           },
+	{ "Seagate STT20000A",          "ALL"           },
 	{ NULL			,	NULL		}
 
 };

-- 
http://www.codemonkey.org.uk

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Add Seagate STT20000A to DMA blacklist.
  2007-05-21 14:50 Dave Jones
@ 2007-05-21 16:15 ` Alan Cox
  2007-05-21 17:27   ` Dave Jones
  2007-05-24  0:33 ` Bartlomiej Zolnierkiewicz
  1 sibling, 1 reply; 7+ messages in thread
From: Alan Cox @ 2007-05-21 16:15 UTC (permalink / raw)
  To: Dave Jones; +Cc: Linux Kernel, bzolnier, linux-ide

On Mon, 21 May 2007 10:50:42 -0400
Dave Jones <davej@redhat.com> wrote:

> http://bugzilla.kernel.org/show_bug.cgi?id=1044
> has been open for _four_ years with a patch available.
> Here's a rediffed version of the same.

Please update libata as well when you udpate the blacklists.

Alan

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Add Seagate STT20000A to DMA blacklist.
  2007-05-21 16:15 ` Alan Cox
@ 2007-05-21 17:27   ` Dave Jones
  0 siblings, 0 replies; 7+ messages in thread
From: Dave Jones @ 2007-05-21 17:27 UTC (permalink / raw)
  To: Alan Cox; +Cc: Linux Kernel, bzolnier, linux-ide

On Mon, May 21, 2007 at 05:15:51PM +0100, Alan Cox wrote:
 > On Mon, 21 May 2007 10:50:42 -0400
 > Dave Jones <davej@redhat.com> wrote:
 > 
 > > http://bugzilla.kernel.org/show_bug.cgi?id=1044
 > > has been open for _four_ years with a patch available.
 > > Here's a rediffed version of the same.
 > 
 > Please update libata as well when you udpate the blacklists.

Sure, point me at the table(s) ?

	Dave

-- 
http://www.codemonkey.org.uk

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Add Seagate STT20000A to DMA blacklist.
       [not found]   ` <fa.xozW+S/WBbGA8Gv2z3FmAe/XymA@ifi.uio.no>
@ 2007-05-21 18:19     ` Robert Hancock
  2007-05-21 18:31       ` Dave Jones
  0 siblings, 1 reply; 7+ messages in thread
From: Robert Hancock @ 2007-05-21 18:19 UTC (permalink / raw)
  To: Dave Jones, Alan Cox, Linux Kernel, bzolnier, linux-ide

Dave Jones wrote:
> On Mon, May 21, 2007 at 05:15:51PM +0100, Alan Cox wrote:
>  > On Mon, 21 May 2007 10:50:42 -0400
>  > Dave Jones <davej@redhat.com> wrote:
>  > 
>  > > http://bugzilla.kernel.org/show_bug.cgi?id=1044
>  > > has been open for _four_ years with a patch available.
>  > > Here's a rediffed version of the same.
>  > 
>  > Please update libata as well when you udpate the blacklists.
> 
> Sure, point me at the table(s) ?
> 
> 	Dave
> 

ata_device_blacklist in drivers/ata/libata-core.c

-- 
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Add Seagate STT20000A to DMA blacklist.
  2007-05-21 18:19     ` Add Seagate STT20000A to DMA blacklist Robert Hancock
@ 2007-05-21 18:31       ` Dave Jones
  2007-05-22  0:02         ` Jeff Garzik
  0 siblings, 1 reply; 7+ messages in thread
From: Dave Jones @ 2007-05-21 18:31 UTC (permalink / raw)
  To: Robert Hancock; +Cc: Alan Cox, Linux Kernel, bzolnier, linux-ide

http://bugzilla.kernel.org/show_bug.cgi?id=1044 points out an
additional hard disk that doesn't handle DMA transfers correctly.
This patch is the libata variant of the earlier patch to drivers/ide/

Signed-off-by: Dave Jones <davej@redhat.com>

--- linux-2.6/drivers/ata/libata-core.c~	2007-05-21 14:27:40.000000000 -0400
+++ linux-2.6/drivers/ata/libata-core.c	2007-05-21 14:28:48.000000000 -0400
@@ -3771,6 +3771,7 @@ static const struct ata_blacklist_entry 
 	{ "ATAPI CD-ROM DRIVE 40X MAXIMUM",NULL,ATA_HORKAGE_NODMA },
 	{ "_NEC DV5800A", 	NULL,		ATA_HORKAGE_NODMA },
 	{ "SAMSUNG CD-ROM SN-124","N001",	ATA_HORKAGE_NODMA },
+	{ "Seagate STT20000A", NULL,		ATA_HORKAGE_NODMA },
 
 	/* Weird ATAPI devices */
 	{ "TORiSAN DVD-ROM DRD-N216", NULL,	ATA_HORKAGE_MAX_SEC_128 |

-- 
http://www.codemonkey.org.uk

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Add Seagate STT20000A to DMA blacklist.
  2007-05-21 18:31       ` Dave Jones
@ 2007-05-22  0:02         ` Jeff Garzik
  0 siblings, 0 replies; 7+ messages in thread
From: Jeff Garzik @ 2007-05-22  0:02 UTC (permalink / raw)
  To: Dave Jones, Robert Hancock, Alan Cox, Linux Kernel, bzolnier,
	linux-ide

Dave Jones wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=1044 points out an
> additional hard disk that doesn't handle DMA transfers correctly.
> This patch is the libata variant of the earlier patch to drivers/ide/
> 
> Signed-off-by: Dave Jones <davej@redhat.com>

applied



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Add Seagate STT20000A to DMA blacklist.
  2007-05-21 14:50 Dave Jones
  2007-05-21 16:15 ` Alan Cox
@ 2007-05-24  0:33 ` Bartlomiej Zolnierkiewicz
  1 sibling, 0 replies; 7+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-05-24  0:33 UTC (permalink / raw)
  To: Dave Jones; +Cc: Linux Kernel, linux-ide

On Monday 21 May 2007, Dave Jones wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=1044
> has been open for _four_ years with a patch available.
> Here's a rediffed version of the same.
> 
> Signed-off-by: Dave Jones <davej@redhat.com>

Uh, it seems that this fix got stuck in the kernel "black hole"
bugzilla.  Thanks for finding and resurrecting it.  

I've just applied the bigger DMA blacklist update from
Junio C Hamano and it also covers this device.

Bart

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2007-05-24  1:24 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <fa.6aGWKqGWP2vDWJvVhFqggIUaWVk@ifi.uio.no>
     [not found] ` <fa.70JldrzRTUl84Jt2lSquANqNr2Q@ifi.uio.no>
     [not found]   ` <fa.xozW+S/WBbGA8Gv2z3FmAe/XymA@ifi.uio.no>
2007-05-21 18:19     ` Add Seagate STT20000A to DMA blacklist Robert Hancock
2007-05-21 18:31       ` Dave Jones
2007-05-22  0:02         ` Jeff Garzik
2007-05-21 14:50 Dave Jones
2007-05-21 16:15 ` Alan Cox
2007-05-21 17:27   ` Dave Jones
2007-05-24  0:33 ` Bartlomiej Zolnierkiewicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).