From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [git patches] libata fixes Date: Fri, 25 May 2007 20:15:20 -0400 Message-ID: <46577C18.8000602@garzik.org> References: <200705260006.l4Q06GsK020585@harpo.it.uu.se> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:59289 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752801AbXEZAP0 (ORCPT ); Fri, 25 May 2007 20:15:26 -0400 In-Reply-To: <200705260006.l4Q06GsK020585@harpo.it.uu.se> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Mikael Pettersson Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro Mikael Pettersson wrote: > On Fri, 25 May 2007 18:03:07 -0400, Jeff Garzik wrote: >> Jeff Garzik (4): >> [libata] sata_promise: fix flags typo > ... >> --- a/drivers/ata/sata_promise.c >> +++ b/drivers/ata/sata_promise.c >> @@ -297,7 +297,7 @@ static const struct ata_port_info pdc_port_info[] = { >> >> /* board_2057x_pata */ >> { >> - .flags = PDC_COMMON_FLAGS | ATA_FLAG_SLAVE_POSS, >> + .flags = PDC_COMMON_FLAGS | ATA_FLAG_SLAVE_POSS | >> PDC_FLAG_GEN_II, >> .pio_mask = 0x1f, /* pio0-4 */ >> .mwdma_mask = 0x07, /* mwdma0-2 */ > > Acked-by: Mikael Pettersson > > Good catch. This typo would have prevented pdc_host_intr() > from detecting GEN_II-specific errors on the PATA port. Oops -- I should have credited Al Viro for the catch, in the changelog. This email hereby corrects the record :) Jeff