From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] pata_sis: FIFO whack
Date: Mon, 28 May 2007 18:01:53 -0400 [thread overview]
Message-ID: <465B5151.4090504@garzik.org> (raw)
In-Reply-To: <20070525205024.2f83995d@the-village.bc.nu>
Alan Cox wrote:
> If you are using a SiS controller and the BIOS didn't set it up then the
> FIFO may be left active when we try and set up the CD. Not convinced this
> matters but I'd prefer to be safe
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.22-rc2-mm1/drivers/ata/pata_sis.c linux-2.6.22-rc2-mm1/drivers/ata/pata_sis.c
> --- linux.vanilla-2.6.22-rc2-mm1/drivers/ata/pata_sis.c 2007-05-25 17:39:06.000000000 +0100
> +++ linux-2.6.22-rc2-mm1/drivers/ata/pata_sis.c 2007-05-25 18:22:21.000000000 +0100
> @@ -149,6 +149,9 @@
> if (!pci_test_config_bits(pdev, &sis_enable_bits[ap->port_no]))
> return -ENOENT;
>
> + /* Clear the FIFO settings. We can't enable the FIFO until
> + we know we are poking at a disk */
> + pci_write_config_byte(pdev, 0x4B, 0);
> return ata_std_prereset(ap, deadline);
Should I queue this into #upstream (2.6.23) or #upstream-fixes
(2.6.22-rc) branch?
I lean towards #upstream since it is so late in the 2.6.22-rc cycle,
because of your comment "Not convinced this matters".
Jeff
parent reply other threads:[~2007-05-28 22:01 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20070525205024.2f83995d@the-village.bc.nu>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465B5151.4090504@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).