* Re: [PATCH] pata_sis: FIFO whack
[not found] <20070525205024.2f83995d@the-village.bc.nu>
@ 2007-05-28 22:01 ` Jeff Garzik
0 siblings, 0 replies; only message in thread
From: Jeff Garzik @ 2007-05-28 22:01 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-kernel, IDE/ATA development list
Alan Cox wrote:
> If you are using a SiS controller and the BIOS didn't set it up then the
> FIFO may be left active when we try and set up the CD. Not convinced this
> matters but I'd prefer to be safe
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.22-rc2-mm1/drivers/ata/pata_sis.c linux-2.6.22-rc2-mm1/drivers/ata/pata_sis.c
> --- linux.vanilla-2.6.22-rc2-mm1/drivers/ata/pata_sis.c 2007-05-25 17:39:06.000000000 +0100
> +++ linux-2.6.22-rc2-mm1/drivers/ata/pata_sis.c 2007-05-25 18:22:21.000000000 +0100
> @@ -149,6 +149,9 @@
> if (!pci_test_config_bits(pdev, &sis_enable_bits[ap->port_no]))
> return -ENOENT;
>
> + /* Clear the FIFO settings. We can't enable the FIFO until
> + we know we are poking at a disk */
> + pci_write_config_byte(pdev, 0x4B, 0);
> return ata_std_prereset(ap, deadline);
Should I queue this into #upstream (2.6.23) or #upstream-fixes
(2.6.22-rc) branch?
I lean towards #upstream since it is so late in the 2.6.22-rc cycle,
because of your comment "Not convinced this matters".
Jeff
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-05-28 22:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20070525205024.2f83995d@the-village.bc.nu>
2007-05-28 22:01 ` [PATCH] pata_sis: FIFO whack Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).