From: Jeff Garzik <jeff@garzik.org>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 2.6.21-mm1 2/2] sata_promise: SATAII-150/300 TX4 port numbering fix
Date: Fri, 01 Jun 2007 16:28:36 -0400 [thread overview]
Message-ID: <46608174.6050900@garzik.org> (raw)
In-Reply-To: <17986.57019.188142.60725@alkaid.it.uu.se>
Mikael Pettersson wrote:
> Jeff Garzik writes:
> > > + if ((pi->flags & (PDC_FLAG_GEN_II|PDC_FLAG_4_PORTS)) == (PDC_FLAG_GEN_II|PDC_FLAG_4_PORTS)) {
> > > + is_sataii_tx4 = 1;
> > > + dev_printk(KERN_INFO, &pdev->dev, "applying SATAII TX4 port numbering workaround\n");
> >
> > ...though I'm not sure the printk is really wanted. nonetheless, I
> > applied it.
>
> Thanks.
>
> There's also the older "PATA port found\n", which is redundant
> since libata will print "PATA" as it logs the corresponding ata dev.
> I can remove both if you like.
Agreed, that would be nice.
Jeff
prev parent reply other threads:[~2007-06-01 20:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-06 20:14 [PATCH 2.6.21-mm1 2/2] sata_promise: SATAII-150/300 TX4 port numbering fix Mikael Pettersson
2007-05-10 0:16 ` Jeff Garzik
2007-05-10 8:58 ` Mikael Pettersson
2007-06-01 20:28 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46608174.6050900@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).