From: Uwe Koziolek <uwe.koziolek@gmx.net>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jgarzik@pobox.com>, "linux.ide" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 2.6.22-rc2] libata: sata_sis fixes
Date: Mon, 04 Jun 2007 22:24:50 +0200 [thread overview]
Message-ID: <46647512.1000408@gmx.net> (raw)
In-Reply-To: <20070604163022.1adf136f@the-village.bc.nu>
How should I proceed. I can submit both patches:
>> - exclude SiS180 from enable bit checking or
>> - exclude MuTol ATA133 from enable bit checking with different
>> error_handler.
>>
>
> Been away but - SiS180 wants excluding anyway according to all the docs,
> the MuToL does appear to be working correctly with enable bits and we've
> got no failure cases in old/new IDE so leave it alone (for now anyway)
>
I have checked some SiS 5513 config spaces with ATA133 for the enable
bits. In all cases Alans
code would work. But I dont know why the necesary bits are set. May be
the hardware is different
to the documentation or the BIOS is setting these bits for compatibility
issue.
The change of the error handler for SiS180 is really needed. The change
of the errorhandler for
Pre ATA133 chips is not reasonable. The change of the errorhandler
for SiS5513 ATA133
controller is not mandatory.
My suggestion: exclude only the SiS180 from the enable bits.
But i want to have an ok , or a vote for the other variant.
Uwe
next prev parent reply other threads:[~2007-06-04 20:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 7:48 [PATCH 2.6.22-rc2] libata: sata_sis fixes Uwe Koziolek
2007-05-25 8:23 ` Jeff Garzik
2007-05-25 14:32 ` Alan Cox
2007-05-30 8:20 ` Uwe Koziolek
2007-06-04 15:30 ` Alan Cox
2007-06-04 20:24 ` Uwe Koziolek [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-05-23 23:31 Uwe Koziolek
2007-05-24 0:22 ` Alan Cox
2007-05-24 6:09 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46647512.1000408@gmx.net \
--to=uwe.koziolek@gmx.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).