From: Tejun Heo <htejun@gmail.com>
To: shyam_iyer@dell.com
Cc: linux-ide@vger.kernel.org
Subject: Re: [PROBLEM + PATCH] Sata port disabled by BIOS gets initialized by ata_piix drive
Date: Sat, 09 Jun 2007 14:51:51 +0900 [thread overview]
Message-ID: <466A3FF7.4090302@gmail.com> (raw)
In-Reply-To: <9493.1181310368198.JavaMail.root@wombat.diezmil.com>
shyam_iyer@dell.com wrote:
> Problem Sata disks are connected to onboard sata ports of PowerEdge
> 1900 (ESB2 southbridge chipset). If one of the port is disabled in
> the bios then they get enabled again by the ata_piix driver because
> of a default port map being written to the Port control and status
> register(0x91-93). Instead the driver should preserve the bios
> setting by way of a fix like this.
What happens if the port is enabled by the kernel?
> Fix: The BIOS configured PCS value must be anded logically with the
> default port map for the chipset. This way the BIOS information will
> not be lost by the reinitialization of the config space by the
> ata_piix driver. The below patch is against 2.6.21 kernel.
I'm not sure whether this is a good idea and it has potential to break a
lot of other configurations. That part of code is used for *all*
ata_piix out there, so we need a really really good reason to change
that. So, please explain what you're trying to fix better.
--
tejun
next prev parent reply other threads:[~2007-06-09 5:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 13:46 [PROBLEM + PATCH] Sata port disabled by BIOS gets initialized by ata_piix drive shyam_iyer
2007-06-09 5:51 ` Tejun Heo [this message]
2007-06-11 13:32 ` Re: [PROBLEM + PATCH] Sata port disabled by BIOS gets initialized shyam_iyer
2007-06-11 17:54 ` Tejun Heo
2007-06-12 18:31 ` Matt Sealey
2007-06-14 9:27 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466A3FF7.4090302@gmail.com \
--to=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=shyam_iyer@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).