* [PATCH] [2.6.22] libata: fix probe time irq printouts
@ 2007-06-03 23:35 Olof Johansson
2007-06-10 2:42 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Olof Johansson @ 2007-06-03 23:35 UTC (permalink / raw)
To: jgarzik; +Cc: linux-kernel, linux-ide
Most drivers don't seem to fill out the host->irq field, resulting in the
wrong (no) irq being reported at probe time. For example, sil24 on my system:
ata1: SATA max UDMA/100 cmd 0xd00008009001f000 ctl 0x0000000000000000 bmdma 0x0000000000000000 irq 0
ata2: SATA max UDMA/100 cmd 0xd000080090021000 ctl 0x0000000000000000 bmdma 0x0000000000000000 irq 0
Since they're allocated and set up in ata_host_activate(), just save
them away there.
Signed-off-by: Olof Johansson <olof@lixom.net>
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index af62514..7491b11 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -6438,6 +6438,9 @@ int ata_host_activate(struct ata_host *host, int irq,
if (rc)
devm_free_irq(host->dev, irq, host);
+ /* Used to print device info at probe */
+ host->irq = irq;
+
return rc;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [2.6.22] libata: fix probe time irq printouts
2007-06-03 23:35 [PATCH] [2.6.22] libata: fix probe time irq printouts Olof Johansson
@ 2007-06-10 2:42 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-06-10 2:42 UTC (permalink / raw)
To: Olof Johansson; +Cc: linux-kernel, linux-ide
Olof Johansson wrote:
> Most drivers don't seem to fill out the host->irq field, resulting in the
> wrong (no) irq being reported at probe time. For example, sil24 on my system:
>
> ata1: SATA max UDMA/100 cmd 0xd00008009001f000 ctl 0x0000000000000000 bmdma 0x0000000000000000 irq 0
> ata2: SATA max UDMA/100 cmd 0xd000080090021000 ctl 0x0000000000000000 bmdma 0x0000000000000000 irq 0
>
> Since they're allocated and set up in ata_host_activate(), just save
> them away there.
>
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
>
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index af62514..7491b11 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -6438,6 +6438,9 @@ int ata_host_activate(struct ata_host *host, int irq,
> if (rc)
> devm_free_irq(host->dev, irq, host);
>
> + /* Used to print device info at probe */
> + host->irq = irq;
> +
applied, thanks for fixing that
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-10 2:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-03 23:35 [PATCH] [2.6.22] libata: fix probe time irq printouts Olof Johansson
2007-06-10 2:42 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).