* [PATCH libata-dev#upstream-fixes] libata: force PIO on IOMEGA ZIP 250 ATAPI
@ 2007-06-10 5:52 Tejun Heo
2007-06-10 15:22 ` Alan Cox
2007-06-11 5:00 ` Jeff Garzik
0 siblings, 2 replies; 5+ messages in thread
From: Tejun Heo @ 2007-06-10 5:52 UTC (permalink / raw)
To: Jeff Garzik, linux-ide, calvin.walton, alan
IOMEGA ZIP 250 ATAPI claims MWDMA0 support but fails SETXFERMODE if
asked to configure itself to MWDMA0. Force PIO.
This fixes bugzilla bug#8497.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Calvin Walton <calvin.walton@gmail.com>
---
There was another proposed patch which lowers transfer mode if device
rejects transfer mode but I'm not sure whether that's the right thing
to do. Such behavior change might affect other devices, so I'm opting
for blacklisting for now.
Thanks.
drivers/ata/libata-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 4733f00..6312a21 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -3769,6 +3769,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
{ "_NEC DV5800A", NULL, ATA_HORKAGE_NODMA },
{ "SAMSUNG CD-ROM SN-124","N001", ATA_HORKAGE_NODMA },
{ "Seagate STT20000A", NULL, ATA_HORKAGE_NODMA },
+ { "IOMEGA ZIP 250 ATAPI", NULL, ATA_HORKAGE_NODMA },
/* Weird ATAPI devices */
{ "TORiSAN DVD-ROM DRD-N216", NULL, ATA_HORKAGE_MAX_SEC_128 |
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH libata-dev#upstream-fixes] libata: force PIO on IOMEGA ZIP 250 ATAPI
2007-06-10 5:52 [PATCH libata-dev#upstream-fixes] libata: force PIO on IOMEGA ZIP 250 ATAPI Tejun Heo
@ 2007-06-10 15:22 ` Alan Cox
2007-06-10 17:03 ` Bartlomiej Zolnierkiewicz
2007-06-11 5:00 ` Jeff Garzik
1 sibling, 1 reply; 5+ messages in thread
From: Alan Cox @ 2007-06-10 15:22 UTC (permalink / raw)
To: Tejun Heo; +Cc: Jeff Garzik, linux-ide, calvin.walton
On Sun, 10 Jun 2007 14:52:36 +0900
Tejun Heo <htejun@gmail.com> wrote:
> IOMEGA ZIP 250 ATAPI claims MWDMA0 support but fails SETXFERMODE if
> asked to configure itself to MWDMA0. Force PIO.
This is only really a temporary fix. It appears to manage MWDMA0 in some
cases with old IDE..
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH libata-dev#upstream-fixes] libata: force PIO on IOMEGA ZIP 250 ATAPI
2007-06-10 15:22 ` Alan Cox
@ 2007-06-10 17:03 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-06-10 17:03 UTC (permalink / raw)
To: Alan Cox; +Cc: Tejun Heo, Jeff Garzik, linux-ide, calvin.walton
On Sunday 10 June 2007, Alan Cox wrote:
> On Sun, 10 Jun 2007 14:52:36 +0900
> Tejun Heo <htejun@gmail.com> wrote:
>
> > IOMEGA ZIP 250 ATAPI claims MWDMA0 support but fails SETXFERMODE if
> > asked to configure itself to MWDMA0. Force PIO.
>
> This is only really a temporary fix. It appears to manage MWDMA0 in some
> cases with old IDE..
Tejun, please add the comment that this is a libata issue so nobody ever
tries to sync this blacklist entry with ide-dma.c.
Thanks,
Bart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH libata-dev#upstream-fixes] libata: force PIO on IOMEGA ZIP 250 ATAPI
2007-06-10 5:52 [PATCH libata-dev#upstream-fixes] libata: force PIO on IOMEGA ZIP 250 ATAPI Tejun Heo
2007-06-10 15:22 ` Alan Cox
@ 2007-06-11 5:00 ` Jeff Garzik
2007-06-11 5:07 ` Tejun Heo
1 sibling, 1 reply; 5+ messages in thread
From: Jeff Garzik @ 2007-06-11 5:00 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide, calvin.walton, alan
Tejun Heo wrote:
> IOMEGA ZIP 250 ATAPI claims MWDMA0 support but fails SETXFERMODE if
> asked to configure itself to MWDMA0. Force PIO.
>
> This fixes bugzilla bug#8497.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Calvin Walton <calvin.walton@gmail.com>
> ---
> There was another proposed patch which lowers transfer mode if device
> rejects transfer mode but I'm not sure whether that's the right thing
> to do. Such behavior change might affect other devices, so I'm opting
> for blacklisting for now.
>
> Thanks.
>
> drivers/ata/libata-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 4733f00..6312a21 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -3769,6 +3769,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
> { "_NEC DV5800A", NULL, ATA_HORKAGE_NODMA },
> { "SAMSUNG CD-ROM SN-124","N001", ATA_HORKAGE_NODMA },
> { "Seagate STT20000A", NULL, ATA_HORKAGE_NODMA },
> + { "IOMEGA ZIP 250 ATAPI", NULL, ATA_HORKAGE_NODMA }, /* temporary fix */
applied, after adding the "temporary fix" comment based on Alan's comments
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH libata-dev#upstream-fixes] libata: force PIO on IOMEGA ZIP 250 ATAPI
2007-06-11 5:00 ` Jeff Garzik
@ 2007-06-11 5:07 ` Tejun Heo
0 siblings, 0 replies; 5+ messages in thread
From: Tejun Heo @ 2007-06-11 5:07 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide, calvin.walton, alan
Jeff Garzik wrote:
> Tejun Heo wrote:
>> @@ -3769,6 +3769,7 @@ static const struct ata_blacklist_entry
>> ata_device_blacklist [] = {
>> { "_NEC DV5800A", NULL, ATA_HORKAGE_NODMA },
>> { "SAMSUNG CD-ROM SN-124","N001", ATA_HORKAGE_NODMA },
>> { "Seagate STT20000A", NULL, ATA_HORKAGE_NODMA },
>> + { "IOMEGA ZIP 250 ATAPI", NULL, ATA_HORKAGE_NODMA }, /*
>> temporary fix */
>
> applied, after adding the "temporary fix" comment based on Alan's comments
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-06-11 5:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-10 5:52 [PATCH libata-dev#upstream-fixes] libata: force PIO on IOMEGA ZIP 250 ATAPI Tejun Heo
2007-06-10 15:22 ` Alan Cox
2007-06-10 17:03 ` Bartlomiej Zolnierkiewicz
2007-06-11 5:00 ` Jeff Garzik
2007-06-11 5:07 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).