Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

[Jeff Garzik <jeff@garzik.org>]

Dagfinn Ilmari Mannsåker wrote:
> Arjan van de Ven <arjan@linux.intel.com> writes:
> 
>> Henrique de Moraes Holschuh wrote:
>>> On Mon, 11 Jun 2007, Kristen Carlson Accardi wrote:
>>>> Setting		Effect
>>>> ----------------------------------------------------------
>>>> min_power	ALPM is enabled, and link set to enter 		lowest
>>>> power state (SLUMBER) when idle
>>>> 		Hot plug not allowed.
>>>>
>>>> max_performance	ALPM is disabled, Hot Plug is allowed
>>>>
>>>> medium_power	ALPM is enabled, and link set to enter
>>>> 		second lowest power state (PARTIAL) when
>>>> 		idle.  Hot plug not allowed.
>>> Just some food for thought:
>>> If you split it into a enable/disable (0/1) attribute, and a level
>>> attribute
>> on/off doesn't really make sense if the question is "do you favor power
>> or do you favor performance".......
> 
> How about just making it a numeric scale with 0 meaning no power saving
> and then some fixed number of levels (e.g 0-9)?

The original proposal seems far more intuitive than these alternatives.

	Jeff