From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 2.6.22-rc5] libata: add HTS541616J9SA00 to NCQ blacklist Date: Mon, 25 Jun 2007 11:49:55 +0900 Message-ID: <467F2D53.2000202@gmail.com> References: <467EC909.9040006@shaw.ca> <467F2495.3080509@gmail.com> <467F286B.40607@gmail.com> <467F2ADF.1040600@shaw.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from wa-out-1112.google.com ([209.85.146.181]:36604 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752285AbXFYCt7 (ORCPT ); Sun, 24 Jun 2007 22:49:59 -0400 Received: by wa-out-1112.google.com with SMTP id v27so1644565wah for ; Sun, 24 Jun 2007 19:49:59 -0700 (PDT) In-Reply-To: <467F2ADF.1040600@shaw.ca> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Robert Hancock Cc: Jeff Garzik , Andrew Morton , enricoss@tiscali.it, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Robert Hancock wrote: > Tejun Heo wrote: >> Another member of HTS5416* family doing spurious NCQ completion. >> >> Signed-off-by: Tejun Heo >> Cc: Enrico Sardi >> --- >> drivers/ata/libata-core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c >> index adfae9d..fbca8d8 100644 >> --- a/drivers/ata/libata-core.c >> +++ b/drivers/ata/libata-core.c >> @@ -3803,6 +3803,7 @@ static const struct ata_blacklist_entry >> ata_device_blacklist [] = { >> /* Drives which do spurious command completion */ >> { "HTS541680J9SA00", "SB2IC7EP", ATA_HORKAGE_NONCQ, }, >> { "HTS541612J9SA00", "SBDIC7JP", ATA_HORKAGE_NONCQ, }, >> + { "Hitachi HTS541616J9SA00", "SB4OC70P", ATA_HORKAGE_NONCQ, }, >> { "WDC WD740ADFD-00NLR1", NULL, ATA_HORKAGE_NONCQ, }, >> >> /* Devices with NCQ limits */ >> > > Is that the right ID string? Strange that that one has Hitachi at the > front and the others don't.. Yeah, I realized that and asked Enrico about it. :-) -- tejun