* [PATCH 2.6.22-rc5] libata: kill non-sense warning message
@ 2007-06-25 12:11 Tejun Heo
2007-06-27 6:45 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2007-06-25 12:11 UTC (permalink / raw)
To: Jeff Garzik, linux-ide@vger.kernel.org
prereset() is now allowed to set flag for unsupported reset method.
EH layer is responsible for selecting the fallback. Remove non-sense
warning message.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/ata/libata-eh.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index d807098..376f004 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -1665,8 +1665,6 @@ static int ata_eh_reset(struct ata_port *ap, int classify,
/* did prereset() screw up? if so, fix up to avoid oopsing */
if (!reset) {
- ata_port_printk(ap, KERN_ERR, "BUG: prereset() requested "
- "invalid reset type\n");
if (softreset)
reset = softreset;
else
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 2.6.22-rc5] libata: kill non-sense warning message
2007-06-25 12:11 [PATCH 2.6.22-rc5] libata: kill non-sense warning message Tejun Heo
@ 2007-06-27 6:45 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-06-27 6:45 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide@vger.kernel.org
Tejun Heo wrote:
> prereset() is now allowed to set flag for unsupported reset method.
> EH layer is responsible for selecting the fallback. Remove non-sense
> warning message.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-eh.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index d807098..376f004 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -1665,8 +1665,6 @@ static int ata_eh_reset(struct ata_port *ap, int classify,
>
> /* did prereset() screw up? if so, fix up to avoid oopsing */
> if (!reset) {
> - ata_port_printk(ap, KERN_ERR, "BUG: prereset() requested "
> - "invalid reset type\n");
> if (softreset)
> reset = softreset;
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-27 6:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-25 12:11 [PATCH 2.6.22-rc5] libata: kill non-sense warning message Tejun Heo
2007-06-27 6:45 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).