* [PATCH 2.6.22-rc5] libata: fix ata_dev_disable()
@ 2007-06-25 14:34 Tejun Heo
2007-06-27 6:45 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2007-06-25 14:34 UTC (permalink / raw)
To: Jeff Garzik, linux-ide@vger.kernel.org
Fix silly condition check bug in ata_dev_disable().
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/ata/libata-core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index adfae9d..09ade2a 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -600,8 +600,9 @@ static const char *sata_spd_string(unsigned int spd)
void ata_dev_disable(struct ata_device *dev)
{
- if (ata_dev_enabled(dev) && ata_msg_drv(dev->ap)) {
- ata_dev_printk(dev, KERN_WARNING, "disabled\n");
+ if (ata_dev_enabled(dev)) {
+ if (ata_msg_drv(dev->ap))
+ ata_dev_printk(dev, KERN_WARNING, "disabled\n");
ata_down_xfermask_limit(dev, ATA_DNXFER_FORCE_PIO0 |
ATA_DNXFER_QUIET);
dev->class++;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 2.6.22-rc5] libata: fix ata_dev_disable()
2007-06-25 14:34 [PATCH 2.6.22-rc5] libata: fix ata_dev_disable() Tejun Heo
@ 2007-06-27 6:45 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-06-27 6:45 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide@vger.kernel.org
Tejun Heo wrote:
> Fix silly condition check bug in ata_dev_disable().
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index adfae9d..09ade2a 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -600,8 +600,9 @@ static const char *sata_spd_string(unsigned int spd)
>
> void ata_dev_disable(struct ata_device *dev)
> {
> - if (ata_dev_enabled(dev) && ata_msg_drv(dev->ap)) {
> - ata_dev_printk(dev, KERN_WARNING, "disabled\n");
> + if (ata_dev_enabled(dev)) {
> + if (ata_msg_drv(dev->ap))
> + ata_dev_printk(dev, KERN_WARNING, "disabled\n");
> ata_down_xfermask_limit(dev, ATA_DNXFER_FORCE_PIO0 |
> ATA_DNXFER_QUIET);
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-27 6:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-25 14:34 [PATCH 2.6.22-rc5] libata: fix ata_dev_disable() Tejun Heo
2007-06-27 6:45 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).