From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] piix: backport short cables support from ata_piix.c
Date: Tue, 26 Jun 2007 22:30:28 +0400 [thread overview]
Message-ID: <46815B44.1040609@ru.mvista.com> (raw)
In-Reply-To: <200706101558.14511.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> Backport short cables support from ata_piix.c.
> This patch should allow UDMA > 2 modes on:
> - Acer 5602WLMi
> - Acer 3682WLMi
> - Asus W5F
> - Acer Aspire 2023WLMi
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Minor nit here:
> Index: b/drivers/ide/pci/piix.c
> ===================================================================
> --- a/drivers/ide/pci/piix.c
> +++ b/drivers/ide/pci/piix.c
> @@ -394,12 +394,43 @@ static void piix_dma_clear_irq(ide_drive
[...]
> static u8 __devinit piix_cable_detect(ide_hwif_t *hwif)
> {
> - struct pci_dev *dev = hwif->pci_dev;
> + struct pci_dev *pdev = hwif->pci_dev;
Unnecessary rename.
> + const struct ich_laptop *lap = &ich_laptop[0];
... and & and [0] are superfluous with arrays -- they behave like pointers
in expression.
MBR, Sergei
next prev parent reply other threads:[~2007-06-26 18:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-10 13:58 [PATCH 2/5] piix: backport short cables support from ata_piix.c Bartlomiej Zolnierkiewicz
2007-06-26 18:30 ` Sergei Shtylyov [this message]
2007-06-27 19:13 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46815B44.1040609@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).